feat: add ExpectHandler for richer Expect: 100-continue handling#2175
Merged
erikdubbelboer merged 4 commits intovalyala:masterfrom Apr 27, 2026
Merged
Conversation
ContinueHandler only returns a bool, limiting the server to either accepting (100) or rejecting with 417. ExpectHandler allows returning any HTTP status code, and closes the connection on rejection since the client may have already started sending body data per RFC 9110. ExpectHandler takes precedence when both handlers are set. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Allows callers to inspect RemoteAddr, TLS state, or any other connection metadata alongside headers, addressing reviewer feedback. Documents that the response must not be modified by the handler. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
erikdubbelboer
requested changes
Apr 25, 2026
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Contributor
Author
|
All done. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContinueHandler only returns a bool, limiting the server to either accepting (100) or rejecting with 417. ExpectHandler allows returning any HTTP status code, and closes the connection on rejection since the client may have already started sending body data per RFC 9110.
ExpectHandler takes precedence when both handlers are set.