Skip to content

fix: downgrade BrokenPipeError ping log from ERROR to WARNING #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palantir-valiot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: downgrade BrokenPipeError ping log from ERROR to WARNING #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pygqlc/GraphQLClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
and all its methods.

GQLResponse (type variable): [data[field(string)], errors[message(string),
field?(string)]
field?(string)]]
Copy link
Copy Markdown
Author

@palantir-valiot palantir-valiot Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docstring change introduces an extra ]. The original ]] was balanced — [data[field(string)], errors[message(string), field?(string)]] has 3 opening and 3 closing brackets. The new ]]] has 4 closing brackets, making it unbalanced.

'''
import traceback
import time
Expand Down Expand Up @@ -737,6 +737,11 @@ def _ping_pong(self):
self._conn.send(PING_JSON)
ping_count += 1
# No need to log normal ping operations
except (BrokenPipeError, OSError):
if not self.closing:
log(LogLevel.WARNING,
'WSS Pipe broken, nothing to ping')
self.wss_conn_halted = True
except Exception as e:
if not self.closing:
log(LogLevel.ERROR,
Expand Down
Loading