Skip to content

RF2 Integration - #298

Open
jflat06 wants to merge 6 commits into
masterfrom
jflat06/RF2integration
Open

RF2 Integration#298
jflat06 wants to merge 6 commits into
masterfrom
jflat06/RF2integration

Conversation

@jflat06

@jflat06 jflat06 commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

Adds a pose_stack to RF2 function, tests for this function, and hooks for accessing some tmol functions from RF2.

@jflat06 jflat06 mentioned this pull request Apr 17, 2024
@kierandidi

Copy link
Copy Markdown
Collaborator

@jflat06 should we close this PR since RF2 is out of date by now?

@jflat06

jflat06 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

By RF2 out of date, do you mean that nobody uses RF2 now? Or that RF2 has changed in some way such as to not be compatible with this?

@kierandidi

Copy link
Copy Markdown
Collaborator

By RF2 out of date, do you mean that nobody uses RF2 now? Or that RF2 has changed in some way such as to not be compatible with this?

I mean that folks use RF3 and other models now

@fdimaio

fdimaio commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

only reason to maybe keep this is this is super easy to plug rf3 into as well (rf3 uses this format for conf head)

@kierandidi

Copy link
Copy Markdown
Collaborator

Audited against current master/#465. The reverse conversion here hard-codes n_poses=1 and requires external chain lengths, while current tmol now has a batched atomworks_from_pose_stack round trip for the 37-slot model representation and #465 adds the prepared Atom37/Biotite path for modern model outputs and general chemistry. This branch is conflicting and its RF2-specific implementation has no current CPU/CUDA/PyTorch validation. I recommend closing it as superseded; if RF3 needs an exact confidence-head serialization contract, add that as a thin tested adapter over the current AtomWorks mapping rather than reviving this RF2-only path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants