USWDS-Proposals - ADR: Improve modularity in USWDS#24
Open
Conversation
added 2 commits
December 19, 2024 11:23
mejiaj
force-pushed
the
adr/improve-modularity
branch
from
f766615 to
ae2c670
Compare
mejiaj
requested review from
CTGM-Bixal,
amyleadem,
cathybaptista,
heymatthenry,
mahoneycm,
mandylloyd and
thisisdano
heymatthenry
reviewed
Jan 8, 2025
|
|
||
| ## Consequences | ||
|
|
||
| ### Benefits |
Contributor
There was a problem hiding this comment.
suggestion: may be good to explicitly call out performance and bundle size, since the hope is that increasing modularity will make it easier to make each package as small as possible
Author
There was a problem hiding this comment.
@heymatthenry good idea. Tried to capture in f5e50e8.
mejiaj
commented
Jan 24, 2025
|
|
||
| | Date | Status | | ||
| | ---------- | -------- | | ||
| | 2024-12-19 | Proposed | |
Author
There was a problem hiding this comment.
chore: Update status before merge.
Suggested change
| | 2024-12-19 | Proposed | | |
| | 2024-12-19 | Approved | |
mejiaj
commented
Jan 24, 2025
heymatthenry
requested changes
Feb 19, 2025
Contributor
heymatthenry
left a comment
heymatthenry
left a comment
There was a problem hiding this comment.
Couple of small wording suggestions.
@annepetersen Would you like to be included on ADR PRs for wordsmithing purposes?
|
|
||
| ## Context | ||
|
|
||
| USWDS is becoming a set of products, in the form of tools and targets. To improve performance and provide flexibility to teams we should make USWDS more modular by offering products such as: |
Contributor
There was a problem hiding this comment.
Suggested change
| USWDS is becoming a set of products, in the form of tools and targets. To improve performance and provide flexibility to teams we should make USWDS more modular by offering products such as: | |
| USWDS is becoming a set of products, in the form of tools and targets: targets, meaning the formats and code the system will generate, and tools meaning the system components that generate them. To improve performance and provide flexibility to teams we should make USWDS more modular by offering products such as: |
|
|
||
| ## Decision | ||
|
|
||
| We'll create additional products and resources that teams can use individually, such as: utilities, tokens, SASS helpers, and HTML components. |
Contributor
There was a problem hiding this comment.
Suggested change
| We'll create additional products and resources that teams can use individually, such as: utilities, tokens, SASS helpers, and HTML components. | |
| By refactoring existing code and creating new products, such as utilities, tokens, SASS helpers, and HTML components, we will support more modular, composable ways of working. |
Contributor
|
Principle is still true, but the details have changed here, so this'll require some revisions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposal to improve modularity in USWDS. Breaking down the current USWDS package into smaller products will give teams greater flexibility and performance when building applications.
Closes #20.
Testing and review
Preview →