Skip to content

Unify VFS interfaces#2641

Open
rodinaarssen wants to merge 144 commits intomainfrom
unify-vfs-interfaces
Open

Unify VFS interfaces#2641
rodinaarssen wants to merge 144 commits intomainfrom
unify-vfs-interfaces

Conversation

@rodinaarssen
Copy link
Copy Markdown
Member

@rodinaarssen rodinaarssen commented Feb 11, 2026

Closes #2701

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 4.14747% with 624 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (f6d6bbe) to head (f8734a8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...mpl/uri/remote/RemoteExternalResolverRegistry.java 0% 217 Missing ⚠️
...rg/rascalmpl/uri/remote/jsonrpc/RemoteIOError.java 0% 61 Missing ⚠️
...rascalmpl/uri/remote/RascalFileSystemServices.java 0% 60 Missing ⚠️
.../uri/remote/jsonrpc/ISourceLocationChangeType.java 0% 22 Missing ⚠️
...mpl/uri/remote/jsonrpc/ISourceLocationChanged.java 0% 17 Missing ⚠️
.../org/rascalmpl/uri/remote/jsonrpc/CopyRequest.java 0% 16 Missing ⚠️
...g/rascalmpl/uri/remote/jsonrpc/DirectoryEntry.java 0% 16 Missing ⚠️
...rg/rascalmpl/uri/remote/jsonrpc/RenameRequest.java 0% 14 Missing ⚠️
src/org/rascalmpl/uri/URIResolverRegistry.java 31% 10 Missing and 3 partials ⚠️
...org/rascalmpl/uri/remote/jsonrpc/WatchRequest.java 0% 12 Missing ⚠️
... and 33 more
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #2641    +/-   ##
========================================
- Coverage       46%     46%    -1%     
- Complexity    6725    6731     +6     
========================================
  Files          794     828    +34     
  Lines        65923   66516   +593     
  Branches      9888    9951    +63     
========================================
+ Hits         30837   30856    +19     
- Misses       32696   33274   +578     
+ Partials      2390    2386     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@toinehartman toinehartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this (and the companion PR usethesource/rascal-language-servers#967) look like a nice unification and clean-up of interfaces.

Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java
Copy link
Copy Markdown
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's making progress, but it's not there yet.

Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java
Comment thread src/org/rascalmpl/uri/vfs/IRemoteResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/URIResolverRegistry.java
Comment thread src/org/rascalmpl/uri/remote/RascalFileSystemServices.java
Comment thread src/org/rascalmpl/uri/remote/RascalFileSystemServices.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RascalFileSystemServices.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/DirectoryEntry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/RemoteIOError.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/RemoteIOError.java
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt VS Code & rascal lsp to be able to start a repl a rascal version thats not the one shipped with VS Code

3 participants