Conversation
…verRegistry interface
…RemoteIOError's methods
…er registry class
…xed a race that can no longer happen
toinehartman
left a comment
toinehartman
left a comment
There was a problem hiding this comment.
Impressive amount of work again! Although I trust your local testing, I think it would be nice to see an all-green CI by using a test-only snapshot release of Rascal if possible.
| var actualClient = (IBaseLanguageClient) client; | ||
| lspDocumentService.connect(actualClient); | ||
| lspWorkspaceService.connect(actualClient); | ||
| provideClient(actualClient); |
There was a problem hiding this comment.
This is called connect in some other places (IBaseTextDocumentService and BaseWorkspaceService for example.)
|
|
||
| @JsonNotification("rascal/logLevel") | ||
| @JsonNotification("logLevel") | ||
| void setMinimumLogLevel(String level); |
There was a problem hiding this comment.
Not part of your work but perhaps this should just become logLevel?
| } | ||
|
|
||
| /** | ||
| * Attemptes to register all schemes. |
There was a problem hiding this comment.
| * Attemptes to register all schemes. | |
| * Attempts to register all schemes. |
| .filter(s => !this.protectedSchemes.includes(s)) | ||
| // we add support for schemes that look inside a jar | ||
| .concat(schemes | ||
| .filter(s => s !== "jar" && s !== "zip" && s !== "compressed") |
There was a problem hiding this comment.
compressed:? Never seen that before. How can that be used?
| readDirectory(uri: vscode.Uri): [string, vscode.FileType][] | Thenable<[string, vscode.FileType][]> { | ||
| this.logger.trace("[RascalFileSystemInVSCode] readDirectory: ", uri); | ||
| return this.sendRequest<DirectoryListingResponse>(uri, "rascal/vfs/input/list") | ||
| .then(c => c.entries.map(ft => [ft.name, ft.types.reduce((a, i) => a | i)])); |
| private readonly watchListener: WatchEventReceiver; | ||
| private readonly fs: vscode.FileSystem; | ||
| private readonly rascalNativeSchemes: Set<string>; | ||
| private toClear: Disposable[] = []; |
There was a problem hiding this comment.
nit: This is typically called disposables.
| this.logger.trace("[VSCodeFileSystemInRascal] remove: ", req.loc); | ||
| return this.asyncVoidCatcher(this.fs.delete(this.toUri(req.loc), { recursive: req.recursive })); | ||
| } | ||
| async rename(req: RenameRequest): Promise<void> { |
There was a problem hiding this comment.
nit: Can we a white line in between the couple of functions above this one?
2 participants
No description provided.