switched parameter order of rascal/edit event to fix #1049#1059
Merged
rodinaarssen merged 5 commits intomainfrom Apr 16, 2026
Merged
switched parameter order of rascal/edit event to fix #1049#1059rodinaarssen merged 5 commits intomainfrom
rodinaarssen merged 5 commits intomainfrom
Conversation
rodinaarssen
requested changes
Apr 15, 2026
Member
rodinaarssen
left a comment
rodinaarssen
left a comment
There was a problem hiding this comment.
Good catch!
I've added some suggestions.
If this is an important feature many downstream projects depend on, it might be worth it to add a UI test for this.
Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
|
DavyLandman
approved these changes
Apr 16, 2026
rodinaarssen
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1049 which has downstream (unreported) issues in uses of IDEServices::edit in vis::Graph and vis::Chart, salix en salix-contrib, and drAmbiguity.