Repository navigation
Conversation
- 95738f8130be94707cc5cfa786923b8c6ae9de04 packages: scaffold @useblacksmith/sandbox with vendored f... by ajwerner <werner@blacksmith.sh> - 6d2501cd1f04bc88d9b741d1091fa62aa80c66ee *: add shared sandbox providers (#14597) by Paul Bardea <paul@blacksmith.sh> - 27f64cbca435b80dbdac7c7eb47e637bb6b412fd packages: add SandboxClient for the sandbox agent api wit... by ajwerner <werner@blacksmith.sh> - 23f9ff82b0eaa5de6fc26218b16f8e7a6cf4691b backend,packages: rebucket sandbox token throttle; SDK us... by ajwerner <werner@blacksmith.sh> - 367d206d5b300b4ba1b81d5f504e9a62d7395aa3 codesmith,packages,backend: label sandbox lifecycle metri... by Paul Bardea <paul@blacksmith.sh> - 53d67d34c3f62280a8e8a4ec05b76c0827f9ccb4 codesmith,packages: delete mcp stdio sandboxes after 8 ho... by Paul Bardea <paul@blacksmith.sh> - 3b306f25dcc3476f4e672745db3b6924fea77537 backend: accept a list of sandbox domains (SANDBOX_DOMAIN... by ajwerner <werner@blacksmith.sh> - 471b8c62ecd9635e126c3ad79803cd8c2cc86a5c packages: sandbox SDK exposePort/listPorts/unexposePort, ... by ajwerner <werner@blacksmith.sh> - c09908ddcf428a671d7fb5e2376885f772e6409c *: rename oxlint-config to @repo scope and group its rule... by Jacob Hands <jacob@jacobhands.com> - acf228f0a7024941692a29ddf9a95ca351d105b5 *: add a turborepo task graph over the pnpm workspace (#1... by Jacob Hands <jacob@jacobhands.com> - a12027a8c11a757807c7bc1158a227ee1b9cd7f9 *: switch workspace tsconfigs to a shared @repo/typescrip... by Jacob Hands <jacob@jacobhands.com> - 68df0cc5818ecba1e9c552132218507f5c966ad0 codesmith,packages,opencode: use seven-day sandbox inacti... by Paul Bardea <paul@blacksmith.sh> - fbaca5bc65389ce2139ff5b03f9f1b7ccf13d092 *: migrate from prettier to oxfmt [01/02] - tooling (#160... by Jacob Hands <jacob@jacobhands.com> - 9509eb9e3621560aa154b724323411bc7f9db017 backend,packages,codesmith: sandbox sizes are 1/2/4 vCPU,... by ajwerner <werner@blacksmith.sh> - 1cf0308b0f075a083c0b8148347089d5bc28b147 sandbox: reuse agent tokens across connects and hold mint... by Paul Bardea <paul@blacksmith.sh> - 373a22c4d017c961eda0b11d16b2a813856ae35b *: script naming [02/03] - rename package scripts to chec... by Jacob Hands <jhands@blacksmith.sh> - 8dcbb5c039e3598b95f4fa995a5473cf7874495e *: script naming [03/05] - use run-* shims in remaining s... by Jacob Hands <jhands@blacksmith.sh> - 7da9c998d50eb5982f522c0e88f63a60d794ae6f *: script naming [05/05] - fix type-aware lint findings (... by Jacob Hands <jhands@blacksmith.sh> - 350dfe2d606f80af27c552243ad4cab1fcd13a0c packages: add idleTimeoutMs for sandbox streams and disab... by ajwerner <werner@blacksmith.sh> - 7fbb5f01fd06be7bdf38ff2e74a111182007e27e backend, images: image builds ship bs-image to the builde... by ajwerner <werner@blacksmith.sh> - 142365fb5463350a01a01fb684cc0fe03e1eb3cc packages: run sandbox sdk exec on the process primitive s... by ajwerner <werner@blacksmith.sh> - abc38bba4b456a1ccdf3b50b3f7fe0c0207a773f packages: keep the sandbox sdk exec process around for re... by ajwerner <werner@blacksmith.sh> - 4b1deca43159ed8b5c6ec502c429f773695f26f7 backend,packages: clarify sandbox capacity errors and tra... by ajwerner <werner@blacksmith.sh> - 8e459acb00f412939ba8fff70636fe4cfd551297 codesmith,backend: follow sandbox provider policy for pr ... by Paul Bardea <paul@blacksmith.sh> - 2f9d69a2818a193c23eac788e7be7fb6510f247e sandbox-sdk: create takes image (catalog ref or snap-… id... by ajwerner <werner@blacksmith.sh> - 58665d35c00e50be0f5a5334cd8c29a71205e088 packages: reconnect stale sandbox host requests (#17396) by Paul Bardea <paul@blacksmith.sh> - 2b4be8f5238f270cd13c55d731eda24413a38e1e packages: attach, list and detach sticky disks in the san... by Luke Bjerring <lukebjerring@gmail.com> - caa51ae346d3c5c4e04d2b60827c4a67ebc23e3a sdk, codesmith: surface the control plane's 429 concurren... by ajwerner <werner@blacksmith.sh> - 41bc2d5b70bc8e22830f8aeafc341f6095df0b4e packages: mirror the sandbox sdk to packages/typescript o... by ajwerner <werner@blacksmith.sh> - ede564ffe6c09bfc216fc54592130084f676a192 packages: open a pull request per sandbox sdk mirror run ... by ajwerner <werner@blacksmith.sh> GitOrigin-RevId: ede564ffe6c09bfc216fc54592130084f676a192
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8828067. Configure here.
| () => this.controller.abort(new TimeoutError(`request timed out after ${timeoutMs}ms`)), | ||
| timeoutMs, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Already-aborted upstream signal ignored by RequestTimeout
Medium Severity
RequestTimeout's constructor uses addEventListener("abort", ...) to propagate an upstream signal's abort, but per the DOM spec, this listener never fires if the signal is already aborted at construction time. In exec, the caller's rest.signal is the upstream for deadline, and deadline.signal becomes the signal for every sub-request. Because send only checks signal?.throwIfAborted() against deadline.signal (not the original caller signal), the abort is silently lost: exec proceeds for up to timeoutSeconds + timeoutMs instead of failing immediately when handed a pre-aborted signal.
Reviewed by Cursor Bugbot for commit 8828067. Configure here.


Sync @useblacksmith/sandbox from useblacksmith/web
GitOrigin-RevId: ede564ffe6c09bfc216fc54592130084f676a192
Need help on this PR? Tag
@codesmithwith what you need. (Staging)Need help on this PR? Tag
@codesmithwith what you need.