Skip to content

Parvinmh/fix/hint autorefresh resize leak - #2195

Open
Parvinmh wants to merge 2 commits into
masterfrom
Parvinmh/fix/hint-autorefresh-resize-leak
Open

Parvinmh/fix/hint autorefresh resize leak#2195
Parvinmh wants to merge 2 commits into
masterfrom
Parvinmh/fix/hint-autorefresh-resize-leak

Conversation

@Parvinmh

@Parvinmh Parvinmh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
intro-js Ready Ready Preview Aug 7, 2026 9:12am

Request Review

@Parvinmh Parvinmh self-assigned this Aug 7, 2026
@Parvinmh Parvinmh added the bug label Aug 7, 2026
@Parvinmh

Parvinmh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

#2163
@shaked-shlomo

Shaked Shlomo and others added 2 commits August 7, 2026 12:10
disableHintAutoRefresh() called DOMEvent.on() for the 'resize' event
instead of DOMEvent.off(), so disabling auto-refresh removed the 'scroll'
listener but re-attached the 'resize' listener. The handler kept firing
after being disabled and the reference was leaked.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant