fix(schema): reject msgpack struct tag on non-PostgreSQL dialects#1384
Open
kyungseopk1m wants to merge 1 commit into
Open
fix(schema): reject msgpack struct tag on non-PostgreSQL dialects#1384kyungseopk1m wants to merge 1 commit into
kyungseopk1m wants to merge 1 commit into
Conversation
The msgpack appender always encodes the value as a Postgres bytea hex literal, regardless of dialect. Only Postgres parses that back, so on SQLite and MySQL the value was stored as text and failed on scan with a cryptic "unexpected code=5c" error. Return an error at append time when the tag is used on a non-Postgres dialect instead of corrupting the value silently. Fixes uptrace#1219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
,msgpackstruct tag always encodes the value as a Postgres bytea hex literal (\x...) through the hardcoded hex encoder, regardless of dialect. Only Postgres reads that literal back, so on SQLite and MySQL the value is stored as plain text and fails on scan withmsgpack: unexpected code=5c decoding map length— the\(0x5c) at the start of the literal. Same root cause as #519.#519 was closed with the maintainer noting that msgpack is optimized for Postgres and that other databases should use a custom type. So instead of trying to make msgpack round-trip on every dialect, this returns an error when the tag is used on a non-Postgres dialect. The insert now fails fast instead of silently storing a value that can't be read back. The Postgres path is left untouched.
Reproduction
Fixes #1219