Repository navigation
chore(deps): drop the unused esbuild 0.27.7 from the lockfile - #134
Merged
Merged
Conversation
esbuild was only vite's optional peer and nothing uses it; pnpm no longer installs it when it resolves the lockfile again. Removes GHSA-g7r4-m6w7-qqqr (low) from pnpm audit.
Deploying ephe with
|
| Latest commit: |
30a53de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c25ed76.ephe.pages.dev |
| Branch Preview URL: | https://upkeep-esbuild-advisory.ephe.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes esbuild 0.27.7 from
pnpm-lock.yaml. It was only there as vite's optional peer, nothing in the app or its tooling uses it (vite 8 bundles with rolldown), and pnpm no longer installs it when it resolves the lockfile again. That clears GHSA-g7r4-m6w7-qqqr (low: arbitrary file read from esbuild's dev server on Windows) frompnpm audit.Changes
package.jsonandpnpm-workspace.yamlare unchanged.(esbuild@0.27.7)peer suffix going away from the vite 8.3.8 keys of the packages that depend on vite. No other package changes version and none is added.Verification
On a clean
node_modules(no esbuild installed):pnpm install --frozen-lockfilepnpm lint:biomepnpm build(tsc + vite build, not part of CI)pnpm exec playwright install chromiumandCI=1 pnpm test: 13 files, 157 tests passedpnpm audit: esbuild is goneLeft for later
pnpm auditstill lists postcss-selector-parser (pinned exactly by @tailwindcss/typography), and glob, minimatch and deepmerge through vite-plugin-pwa > workbox-build. They need an override or an upstream release.