Skip to content

fix(scroll-area): add max-h-[inherit] to viewport to fix max-height s… #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YassineJlassi123 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(scroll-area): add max-h-[inherit] to viewport to fix max-height s… #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df12d11
fix(scroll-area): add max-h-[inherit] to viewport to fix max-height s…
YassineJlassi123 Mar 24, 2026
32b35b3
fix(scroll-area): add max-h-[inherit] to bases/reka variant
YassineJlassi123 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/v4/registry/bases/reka/ui/scroll-area/ScrollArea.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ const delegatedProps = reactiveOmit(props, "class")
>
<ScrollAreaViewport
data-slot="scroll-area-viewport"
class="cn-scroll-area-viewport focus-visible:ring-ring/50 size-full rounded-[inherit] transition-[color,box-shadow] outline-none focus-visible:ring-[3px] focus-visible:outline-1"
>
class="cn-scroll-area-viewport focus-visible:ring-ring/50 size-full max-h-[inherit] rounded-[inherit] transition-[color,box-shadow] outline-none focus-visible:ring-[3px] focus-visible:outline-1" >
<slot />
</ScrollAreaViewport>
<ScrollBar />
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/ui/scroll-area/ScrollArea.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const delegatedProps = reactiveOmit(props, "class")
>
<ScrollAreaViewport
data-slot="scroll-area-viewport"
class="focus-visible:ring-ring/50 size-full rounded-[inherit] transition-[color,box-shadow] outline-none focus-visible:ring-[3px] focus-visible:outline-1"
class="focus-visible:ring-ring/50 size-full max-h-[inherit] rounded-[inherit] transition-[color,box-shadow] outline-none focus-visible:ring-[3px] focus-visible:outline-1"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
>
<slot />
</ScrollAreaViewport>
Expand Down