Skip to content

fix: watch path overfill#5404

Merged
ogzhanolguncu merged 1 commit intomainfrom
03-20-fix_watch_path_overfill
Mar 23, 2026
Merged

fix: watch path overfill#5404
ogzhanolguncu merged 1 commit intomainfrom
03-20-fix_watch_path_overfill

Conversation

@Flo4604
Copy link
Copy Markdown
Member

@Flo4604 Flo4604 commented Mar 20, 2026

What does this PR do?

This PR improves the watch paths settings UI by removing the empty pattern validation requirement, adding form reset functionality after successful updates, and enhancing the display of multiple watch paths with a truncated view that shows the first path plus a count indicator for additional paths.

The changes also add overflow handling to the selected config badge component to prevent layout issues with long content.

image.png

Fixes #5381

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Navigate to project settings > build settings > watch paths
  • Add multiple watch paths and verify the display shows the first path with a "+N" indicator
  • Test that empty patterns are now allowed in the form
  • Verify that the form resets properly after saving changes
  • Check that long path names don't break the layout

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Mar 20, 2026 5:29pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

Two components were updated: watch-paths-settings component now removes Zod string length validation, adds form reset synchronization after saving, and truncates the displayed path list to show the first path with a "+N" counter for additional entries. The selected-config component adds CSS overflow handling classes to its Badge element.

Changes

Cohort / File(s) Summary
Watch Paths Settings
web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/build-settings/watch-paths-settings.tsx
Zod validation changed from constrained non-empty string to unconstrained z.string(). Form reset now synchronizes state post-submit. Display value changed from full comma-joined list to first path with "+N" counter for additional paths.
Selected Config Styling
web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/selected-config.tsx
Added max-w-full and overflow-hidden CSS classes to Badge component for improved overflow handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title "fix: watch path overfill" is partially related to the changeset - it addresses the overfill/overflow issue in selected-config.tsx but doesn't capture the broader enhancements like validation removal and form reset functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description is comprehensive and follows the template structure. It includes a clear summary of changes, the linked issue (#5381), type of change marked correctly (Enhancement), detailed testing instructions, and the checklist present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 03-20-fix_watch_path_overfill

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member Author

Flo4604 commented Mar 20, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ogzhanolguncu ogzhanolguncu added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit d1c2632 Mar 23, 2026
24 of 25 checks passed
@ogzhanolguncu ogzhanolguncu deleted the 03-20-fix_watch_path_overfill branch March 23, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip empty rows instead of blocking save

3 participants