Skip to content

fix: allow me some more ports#5403

Merged
Flo4604 merged 1 commit intomainfrom
03-20-fix_allow_me_some_more_ports
Mar 20, 2026
Merged

fix: allow me some more ports#5403
Flo4604 merged 1 commit intomainfrom
03-20-fix_allow_me_some_more_ports

Conversation

@Flo4604
Copy link
Copy Markdown
Member

@Flo4604 Flo4604 commented Mar 20, 2026

What does this PR do?

Expands the allowed port range for environment runtime settings from 2000-54000 to the full valid port range of 1-65535.

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test updating environment port with values below 2000 (e.g., 80, 443, 1000)
  • Test updating environment port with values above 54000 (e.g., 60000, 65535)
  • Verify that ports outside the valid range (0, 65536+) are still rejected

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Mar 20, 2026 4:03pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 21dfe373-cede-4f60-9080-248c304330a8

📥 Commits

Reviewing files that changed from the base of the PR and between 8ff289e and 095aafa.

📒 Files selected for processing (1)
  • web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/runtime/update-port.ts

📝 Walkthrough

Walkthrough

Updated the port validation range in the updatePort TRPC procedure from 2000–54000 to the standard TCP port range of 1–65535 via Zod schema constraints. No logic, control flow, or error handling changes were introduced.

Changes

Cohort / File(s) Summary
Port validation range
web/apps/dashboard/lib/trpc/routers/deploy/environment-settings/runtime/update-port.ts
Updated Zod schema validation for port input: changed min: 2000, max: 54000 to min: 1, max: 65535 to allow full TCP port range.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change: expanding the allowed port range in environment runtime settings from 2000-54000 to 1-65535.
Description check ✅ Passed The description clearly explains the purpose of the PR, matches the changeset, and provides testing instructions relevant to the port range expansion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 03-20-fix_allow_me_some_more_ports

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member Author

Flo4604 commented Mar 20, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Flo4604 Flo4604 marked this pull request as ready for review March 20, 2026 16:01
@Flo4604 Flo4604 added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 1e9b4d5 Mar 20, 2026
24 of 25 checks passed
@Flo4604 Flo4604 deleted the 03-20-fix_allow_me_some_more_ports branch March 20, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants