fix: actually not deploying via github connection works

[Flo4604]

What does this PR do?

Fixes the fix that didnt't work

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

• Test deployment workflow with an app that has no GitHub repository connection
• Test deployment workflow with an app that has a valid GitHub repository connection
• Verify that "not found" errors are handled gracefully without causing Restate retries

Checklist

Required

• Filled out the "How to test" section in this PR
• Read Contributing Guide
• Self-reviewed my own code
• Commented on my code in hard-to-understand areas
• Ran pnpm build
• Ran pnpm fmt
• Ran make fmt on /go directory
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Unkey Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Mar 20, 2026 3:22pm

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 464ebea3-b096-4f17-9d5a-8d84a73e4407

📥 Commits

Reviewing files that changed from the base of the PR and between c8ce639 and a70c0ce.

📒 Files selected for processing (2)

• svc/ctrl/worker/deploy/BUILD.bazel
• svc/ctrl/worker/deploy/deploy_handler.go

💤 Files with no reviewable changes (1)

• svc/ctrl/worker/deploy/BUILD.bazel

---

📝 Walkthrough

Walkthrough

The pull request removes MySQL-specific dependencies from the deploy module by eliminating the //pkg/mysql build dependency and replacing MySQL-specific error handling with a generic database "not found" check in the deploy handler's repository connection initialization logic.

Changes

Cohort / File(s)	Summary
MySQL Dependency Removal svc/ctrl/worker/deploy/BUILD.bazel, svc/ctrl/worker/deploy/deploy_handler.go	Removed //pkg/mysql build dependency and replaced mysql.IsNotFound with generic db.IsNotFound in the initGitHubStatus function. Updated error handling to return zero-value db.GithubRepoConnection with nil error on "not found" conditions, and simplified logging by removing conditional suppression and extraneous error fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly references the main fix: enabling deployments when no GitHub connection exists. It accurately reflects the primary change in the changeset.
Description check	✅ Passed	The description includes the required sections with concrete testing instructions and properly marked checkbox selections, though the motivation is vague.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 03-20-fix_actually_not_deploying_via_github_connection_works

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Command failed

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Flo4604]

• fix: actually not deploying via github connection works #5400 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.