Config.uk: auto-select LIBUKRANDOM_LCPU on x86_64 and arm64#73
Open
harimishal1 wants to merge 1 commit intounikraft:stagingfrom
Open
Config.uk: auto-select LIBUKRANDOM_LCPU on x86_64 and arm64#73harimishal1 wants to merge 1 commit intounikraft:stagingfrom
harimishal1 wants to merge 1 commit intounikraft:stagingfrom
Conversation
lwip selects LIBUKRANDOM to obtain randomness for UDP port initialization, but does not select any entropy source. On x86_64 and arm64, the CPU-based RNG (RDRAND/RNDR via LIBUKRANDOM_LCPU) is available and is the natural choice for KVM/QEMU targets. Without this, uk_random_fill_buffer() returns -ENODEV and lwip calls UK_CRASH(), causing a boot-time panic in any application that uses UDP. Tested by building and running catalog-core/click on qemu-x86_64. Signed-off-by: Hari Mishal Signed-off-by: misharu <harimishal1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lwip selects LIBUKRANDOM to obtain randomness for UDP port initialization, but does not select any entropy source. On x86_64 and arm64, the CPU-based RNG (RDRAND/RNDR via LIBUKRANDOM_LCPU) is available and is a good choice for KVM/QEMU targets.
Without this, uk_random_fill_buffer() returns -ENODEV and lwip calls UK_CRASH(), causing a boot-time panic.
Tested by building and running catalog-core/click on qemu-x86_64.