Skip to content

Use trusted publishing - #96

Merged
benkiel merged 8 commits into
unified-font-object:masterfrom
daltonmaag:use-trusted-publishing
Sep 23, 2025
Merged

Use trusted publishing#96
benkiel merged 8 commits into
unified-font-object:masterfrom
daltonmaag:use-trusted-publishing

Conversation

@madig

@madig madig commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

In light of the recent npm supply chain attacks and also https://blog.pypi.org/posts/2025-09-16-github-actions-token-exfiltration/, I'm combing through our font stack to see if all them Py projects are using the trusted publisher mechanism as recommended by PyPI. See https://docs.pypi.org/trusted-publishers/ and https://docs.astral.sh/uv/guides/integration/github/#publishing-to-pypi.

Someone needs to do three things for this PR to work:

  • Create an environment called "publish-to-pypi" in this GitHub repository under Settings -> Environments. Creating alone is probably enough, no configuration needed I think.
  • Follow https://docs.pypi.org/trusted-publishers/adding-a-publisher/ to set up the other side on PyPI.
  • Remove tokens/secret variables here so they can't be exfiltrated anymore, and probably also remove them from PyPI.

(Merge #97 first)

In light of the recent npm supply chain attacks and also https://blog.pypi.org/posts/2025-09-16-github-actions-token-exfiltration/, I'm combing through our font stack to see if all them Py projects are using the trusted publisher mechanism as recommended by PyPI. See https://docs.pypi.org/trusted-publishers/ and https://docs.astral.sh/uv/guides/integration/github/#publishing-to-pypi.

Someone needs to do three things for this PR to work:

* Create an environment called "publish-to-pypi" in this GitHub repository under Settings -> Environments. Creating alone is probably enough, no configuration needed I think.
* Follow https://docs.pypi.org/trusted-publishers/adding-a-publisher/ to set up the other side on PyPI.
* Remove tokens/secret variables here so they can't be exfiltrated anymore, and probably also remove them from PyPI.

I'm not sure if one needs to do anything to make twine pick up the new creds, trusted publishing should be supported in v6.1.0.
@madig
madig force-pushed the use-trusted-publishing branch from 9602656 to 2df209d Compare September 23, 2025 15:02
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.498% (-0.2%) from 87.668%
when pulling 2df209d on daltonmaag:use-trusted-publishing
into 4c0bc02 on unified-font-object:master.

4 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.498% (-0.2%) from 87.668%
when pulling 2df209d on daltonmaag:use-trusted-publishing
into 4c0bc02 on unified-font-object:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.498% (-0.2%) from 87.668%
when pulling 2df209d on daltonmaag:use-trusted-publishing
into 4c0bc02 on unified-font-object:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.498% (-0.2%) from 87.668%
when pulling 2df209d on daltonmaag:use-trusted-publishing
into 4c0bc02 on unified-font-object:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.498% (-0.2%) from 87.668%
when pulling 2df209d on daltonmaag:use-trusted-publishing
into 4c0bc02 on unified-font-object:master.

@benkiel
benkiel merged commit 010795e into unified-font-object:master Sep 23, 2025
6 checks passed
@benkiel

benkiel commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

@madig FWIW, this worked just fine! Thank you for the prompt to do this with each repository and the very helpful PRs.

The Coverage.io thing was just refreshing it. I may just drop Coverage as is, but for now it works.

@madig
madig deleted the use-trusted-publishing branch September 24, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants