Vs/approach spin#207
Open
Beastvr00k wants to merge 45 commits into
Open
Conversation
…ching bad stopping
… individual cmd_vels to move in approach target
…nto VS/approach-spin
ejhon1116
reviewed
Apr 21, 2026
…nto VS/approach-spin
…threshold to two functions, and moving spinning to drive.py
…nto VS/approach-spin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What features did you add, bugs did you fix, etc?
Fixes stopping and adds a way to handle bad exit and makes sure target is in frame
Did you add documentation to the wiki?
No
How was this code tested?
I ran it in sim a bunch of times with a bunch of different configurations
Did you test this in sim?
Yes
Did you test this on the rover?
No
Did you add unit tests?
No