Rendering improvements#146
Open
nevenjohnson wants to merge 16 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What features did you add, bugs did you fix, etc?
Add support for normal mapping in the sim. This improves visual fidelity and can be used to make simulated pointcloud data more detailed. Normal mapping is toggleable in case it produces undesired results for a particular use case.
Also updated shaders to optionally use true PBR (incorporates metallic and roughness values per mesh). This is toggleable through checkbox in the sim GUI.
Did you add documentation to the wiki?
No
How was this code tested?
Tested this code in the sim by toggling normal mapping on and off and by toggling PBR on and off. Performance impact (on my machine) seems negligible.
Did you test this in sim?
Yes
Did you test this on the rover?
No
Did you add unit tests?
No