Skip to content

Add Solov'ev equilibria #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-ashe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Solov'ev equilibria #4114

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
993c57c
Create new branch for Solovev
chris-ashe Feb 26, 2026
a119f1c
Refactor ExtremalPoint class to use dataclass for cleaner initializat…
chris-ashe Feb 26, 2026
e12a53b
Post rebase changes
chris-ashe Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions process/core/io/plot/summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
ElectronCyclotron,
)
from process.models.physics.impurity_radiation import read_impurity_file
from process.models.physics.solovev_equilibrium import plot_analytic_equilibrium
from process.models.physics.l_h_transition import PlasmaConfinementTransitionModel
from process.models.physics.physics import BetaComponentLimits, BetaNormMaxModel
from process.models.physics.plasma_current import (
Expand Down Expand Up @@ -13819,6 +13820,10 @@ def main_plot(

plot_larmor_radius_profile(figs[18].add_subplot(313), m_file, scan)

ax25 = figs[16].add_subplot(222, aspect="equal")
ax25.set_position([0.6, 0.55, 0.45, 0.45])
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a 222 subplot and then sets its position to [0.6, 0.55, 0.45, 0.45], which extends beyond the figure bounds (right edge at 1.05) and may clip content. Also note plot_analytic_equilibrium() creates its own axes inside figs[16], so the layout responsibilities are currently split between caller and callee and can cause overlaps.

Suggested change
ax25 = figs[16].add_subplot(222, aspect="equal")
ax25.set_position([0.6, 0.55, 0.45, 0.45])
ax25 = figs[16].add_axes([0.55, 0.52, 0.35, 0.35], aspect="equal")

Copilot uses AI. Check for mistakes.
plot_analytic_equilibrium(ax25, m_file, scan, figs[16])
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the main changes are in process/io/plot_proc.py with updated figure indexing, but the diff here updates process/core/io/plot/summary.py and adds a new physics module/dependency. Please update the PR description (or include the missing changes) so reviewers can accurately assess scope and impact.

Copilot uses AI. Check for mistakes.

# Plot poloidal cross-section
poloidal_cross_section(
figs[19].add_subplot(121, aspect="equal"),
Expand Down
Loading
Loading