Add graceful.ServeTLS()#5
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds graceful HTTPS serving support to the pkg/graceful package, mirroring the existing signal-based graceful shutdown behavior used for HTTP servers.
Changes:
- Refactors HTTP serving to reuse a new
serveGracefullyhelper. - Adds
graceful.ServeTLS()plus an internallistenAndServeTLS()wrapper. - Adds a new test validating log output for
ServeTLS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| pkg/graceful/serve.go | Introduces ServeTLS and extracts common graceful-shutdown logic into serveGracefully. |
| pkg/graceful/serve_test.go | Adds TLS test coverage for log output and generates an in-memory self-signed cert for the server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mwij02
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a graceful https handler
Checklist