Add test for issue 1671

[msridhar]

See #1671. This passes with our JSpecify experimental flag enabled

Summary by CodeRabbit

• Bug Fixes

  • Improved null-safety analysis for JSpecify-annotated reactive web client code.
  • Improved handling of JSON response mapping and empty-result error fallbacks in reactive chains.
  • Strengthened stream nullability analysis when filtering with common string utility methods.

• Tests

  • Added coverage for reactive WebClient flows using access-token mapping and error handling.
  • Expanded validation of nullability behavior across Spring WebFlux and Jackson integrations.

[msridhar]

This change is part of the following stack:

• Add test for issue 1671 #1673 ◀

_{Change managed by git-spice.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9bd4f34a-5d68-4954-8a75-8ad8d7ef33ec

📥 Commits

Reviewing files that changed from the base of the PR and between 8fcb75c and 4a60bb2.

📒 Files selected for processing (1)

• nullaway/src/test/java/com/uber/nullaway/jspecify/StreamNullabilityPropagatorTests.java

💤 Files with no reviewable changes (1)

• nullaway/src/test/java/com/uber/nullaway/jspecify/StreamNullabilityPropagatorTests.java

---

Walkthrough

Adds Jackson Databind and Spring WebFlux test dependencies through the Gradle version catalog. Adds the issue1671 compilation test for a JSpecify-annotated Spring WebClient chain. The test extracts an access token and handles an empty result with Mono.error. Removes the inline StringUtils stub from the stream nullability test.

Possibly related PRs

• uber/NullAway#1597: Adds related stream nullability test coverage and Spring StringUtils usage.
• uber/NullAway#1646: Adds overlapping JSpecify test configuration and test changes.

Suggested reviewers: yuxincs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a test for issue 1671.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-1671

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@nullaway/src/test/java/com/uber/nullaway/jspecify/WildcardTests.java`:
- Line 1094: Add Javadoc immediately above the `issue1671` test method
describing the JSpecify WebClient access-token flow covered by this multi-step
compilation regression test, following the project’s existing Javadoc style.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 227545b6-6d34-4926-8c3e-5d3cb143e1b2

📥 Commits

Reviewing files that changed from the base of the PR and between e70a56d and 8fcb75c.

📒 Files selected for processing (3)

• gradle/libs.versions.toml
• nullaway/build.gradle
• nullaway/src/test/java/com/uber/nullaway/jspecify/WildcardTests.java

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add Javadoc for issue1671.

This method defines a multi-step compilation regression test. Add Javadoc that identifies the JSpecify WebClient access-token flow that it protects.

As per coding guidelines, “Add Javadoc to every non-trivial method, including private methods.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@nullaway/src/test/java/com/uber/nullaway/jspecify/WildcardTests.java` at line
1094, Add Javadoc immediately above the `issue1671` test method describing the
JSpecify WebClient access-token flow covered by this multi-step compilation
regression test, following the project’s existing Javadoc style.

Source: Coding guidelines

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.78%. Comparing base (e70a56d) to head (4a60bb2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1673      +/-   ##
============================================
+ Coverage     87.75%   87.78%   +0.02%     
- Complexity     3132     3134       +2     
============================================
  Files           109      109              
  Lines         10580    10580              
  Branches       2136     2136              
============================================
+ Hits           9285     9288       +3     
  Misses          615      615              
+ Partials        680      677       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.