ci: Test against Go 1.24 and 1.25

[abhinav]

With the release of Go 1.25, bump CI to run against 1.24 and 1.25,
and bump the minimum required Go version to 1.24
as this is required to use features introduced in Go 1.24.

(We should bump this to at least 1.23 to start using iterators.)

[abhinav]

This change is part of the following stack:

• ci: Test against Go 1.24 and 1.25 #1274 ◀
  • lint: upgrade golangci-lint configuration #1275
    • all: modernize #1276

_{Change managed by git-spice.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (0a30575) to head (f920151).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          35       35           
  Lines        3458     3458           
=======================================
  Hits         3411     3411           
  Misses         40       40           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rabbbit]

Would be nice to say which features from 1.24 we need perhaps?

[abhinav]

Would be nice to say which features from 1.24 we need perhaps?

We need nothing from 1.24 right now but without this we can't use them either.
Directive was 1.22 earlier which means even iterative (1.23) were unusable and I think Fx could definitely lose some slice allocs with iterators.

[rabbbit]

Would be nice to say which features from 1.24 we need perhaps?

We need nothing from 1.24 right now but without this we can't use them either. Directive was 1.22 earlier which means even iterative (1.23) were unusable and I think Fx could definitely lose some slice allocs with iterators.

Interesting - in all cases I've tried to use iterators so far they've turned out to be slower, but I can see how my use cases were "wrong".

[abhinav]

No, you're probably not doing anything wrong here.
I haven't benchmarked them extensively but I'm sure they're slower than iterating through a slice.
I've found them useful in certain cases for making code more readable and writable.
E.g. in Fx somewhere we have a walk function for visiting all modules in a module tree; that would be better expressed with an iterator—easier to read and write.

[rabbbit]

No, you're probably not doing anything wrong here. I haven't benchmarked them extensively but I'm sure they're slower than iterating through a slice. I've found them useful in certain cases for making code more readable and writable. E.g. in Fx somewhere we have a walk function for visiting all modules in a module tree; that would be better expressed with an iterator—easier to read and write.

I didn't say I'm doing anything wrong, I said my use cases were wrong;)