rcv:0.1.0#4889
Conversation
elegaanz
left a comment
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for this package. I left a few comments. The warnings reported by CI would be nice to fix too. Regarding kebab-case, this is not mandatory but still appreciated, as this is the most common naming convention in the Typst ecosystem, and using it makes your package much more "Typst-y".
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
| name = "rcv" | |||
There was a problem hiding this comment.
The name is too canonical in my opinion, which we try to avoid. See our naming guidelines. Can you please pick another name?
|
|
||
| ```typst | ||
|
|
||
| #import "@preview/typst-rcv:0.1.0": ballot_template, choices |
There was a problem hiding this comment.
The import here needs to be updated.
There was a problem hiding this comment.
As far as I can tell, this file is not used anywhere. Can you delete it or use it as an illustration in your README?
There was a problem hiding this comment.
It's used in the template for instructions
There was a problem hiding this comment.
My bad, thank you for pointing it out.
2 participants
I am submitting
Description: Simple RCV ballots
I have read and followed the submission guidelines and, in particular, I
selected a name that isn't the most obvious or canonical name for what the package does
added a
typst.tomlfile with all required keysadded a
README.mdwith documentation for my packagehave chosen a license and added a
LICENSEfile or linked one in myREADME.mdtested my package locally on my system and it worked
excluded PDFs or README images, if any, but not the LICENSEensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.