Skip to content

pass twine publish args in deploy_pip#411

Open
mgosk wants to merge 1 commit into
typedb:masterfrom
mgosk:pip-publish-args
Open

pass twine publish args in deploy_pip#411
mgosk wants to merge 1 commit into
typedb:masterfrom
mgosk:pip-publish-args

Conversation

@mgosk

@mgosk mgosk commented Apr 9, 2024

Copy link
Copy Markdown

What is the goal of this PR?

Be able to pass twine args eg --skip-existing , "--non-interactive"

What are the changes implemented in this PR?

Pass twine publish args in deploy_pip function

Live tested on private repository together with other waiting PRs https://github.com/mgosk/bazel-distribution/tree/bzlmod-with-pypi

@alexjpwalker

alexjpwalker commented Jun 13, 2024

Copy link
Copy Markdown
Member

hi @mgosk , thank you for the contribution!

This change would be more explicit and aligned with the other rules in bazel_distribution if the arguments supported by twine were each individually configurable in the rule's arguments.

Something like

        "skip_existing": attr.bool(
            default = False,
            doc = "Continue uploading files if one already exists. (Only valid when uploading to PyPI. Other implementations may not support this.)"
        ),

@alexjpwalker alexjpwalker self-requested a review June 13, 2024 10:16
@alexjpwalker alexjpwalker self-assigned this Jun 13, 2024

@alexjpwalker alexjpwalker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented in main thread

@krishnangovindraj krishnangovindraj self-assigned this May 26, 2026
@krishnangovindraj

Copy link
Copy Markdown
Member

--skip-existing could be really useful even for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants