Skip to content
This repository was archived by the owner on Sep 18, 2021. It is now read-only.

Destroy session in DefaultSmppClient on bind error#97

Open
phyrex1an wants to merge 1 commit into
twitter-archive:masterfrom
phyrex1an:master
Open

Destroy session in DefaultSmppClient on bind error#97
phyrex1an wants to merge 1 commit into
twitter-archive:masterfrom
phyrex1an:master

Conversation

@phyrex1an

Copy link
Copy Markdown

In case bind fails the caller wont be able to destroy the created
session (if any). In the case of DefaultSmppSession this will
cause the WindowMonitor of the sendWindow to detect a missing
Window.destroy and log an error about this.

This patch destroys the session in cases the session has been
created but wont be returned to the caller.

In case bind fails the caller wont be able to destroy the created
session (if any). In the case of DefaultSmppSession this will
cause the WindowMonitor of the sendWindow to detect a missing
Window.destroy and log an error about this.

This patch destroys the session in cases the session has been
created but wont be returned to the caller.
@CLAassistant

CLAassistant commented Nov 16, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mikael Bung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants