Skip to content
This repository was archived by the owner on Sep 18, 2021. It is now read-only.

Split DefaultSmppSession into DefaultSmppClientSession and DefaultSmppServerSession#111

Open
pgoergler wants to merge 1 commit into
twitter-archive:masterfrom
pgoergler:master-refactoring
Open

Split DefaultSmppSession into DefaultSmppClientSession and DefaultSmppServerSession#111
pgoergler wants to merge 1 commit into
twitter-archive:masterfrom
pgoergler:master-refactoring

Conversation

@pgoergler

Copy link
Copy Markdown

This is just some refactoring.
Before this refactoring DefaultSmppSession had server side methods like serverReady() and has also client side methods like bind(BaseBind, timeout) and submit(SubmitSm, timeout).

DefaultSmppSession became AbstractSmppSession, and it is the base for the class:

  • DefaultSmppClientSession which is in charged of client side sessions and implements the interface SmppClientSession
  • DefaultSmppServerSession which is in charged of server side sessions and implements then interface SmppServerSession

@CLAassistant

CLAassistant commented Nov 16, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paul GOERGLER seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants