feat: add progress bar detail updates#890
Open
zamderax wants to merge 1 commit intotuist:mainfrom
Open
Conversation
zamderax
requested review from
cschmatzler and
fortmarek
and removed request for
a team
dosubot
Bot
added
the
size:L
zamderax
changed the title
zamderax
added a commit
to wendylabsinc/Noora
that referenced
this pull request
Feb 2, 2026
Joannis
reviewed
Feb 3, 2026
| successMessage: String?, | ||
| errorMessage: String?, | ||
| renderer: Rendering, | ||
| task: @escaping (@escaping (ProgressBarUpdate) -> Void) async throws -> V |
Contributor
There was a problem hiding this comment.
Does this conflict with the other overloads in practical use?
Joannis
reviewed
Feb 3, 2026
Comment on lines
+314
to
+316
| successMessage: String?, | ||
| errorMessage: String?, | ||
| renderer: Rendering, |
Contributor
There was a problem hiding this comment.
These three can have default arguments. Which would remove the need for two overloads
Joannis
reviewed
Feb 3, 2026
Comment on lines
+1361
to
+1388
| public func progressBarStep<V>( | ||
| message: String, | ||
| task: @escaping (@escaping (ProgressBarUpdate) -> Void) async throws -> V | ||
| ) async throws -> V { | ||
| try await progressBarStep( | ||
| message: message, | ||
| successMessage: nil, | ||
| errorMessage: nil, | ||
| renderer: Renderer(), | ||
| task: task | ||
| ) | ||
| } | ||
|
|
||
| public func progressBarStep<V>( | ||
| message: String, | ||
| successMessage: String?, | ||
| errorMessage: String?, | ||
| task: @escaping (@escaping (ProgressBarUpdate) -> Void) async throws -> V | ||
| ) async throws -> V { | ||
| try await progressBarStep( | ||
| message: message, | ||
| successMessage: successMessage, | ||
| errorMessage: errorMessage, | ||
| renderer: Renderer(), | ||
| task: task | ||
| ) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
These 2 can be removed if you use default arguments
Contributor
|
@zamderax could you include a gif/video showing the UI of the work? |
pepicrft
reviewed
Feb 26, 2026
|
|
||
| ```swift | ||
| try await Noora().progressStep( | ||
| try await Noora().progressBarStep( |
Contributor
There was a problem hiding this comment.
Does this mean progressStep is a deprecated API? Are we going to maintain both? If so, I find it a bit confusing as a consumer of the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing