Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions .github/agents/analyser.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,21 @@ Bullet points with concrete evidence.
### Risks / Technical Debt
Items that could affect maintainability, correctness, or scalability.

### Score
Give an overall score between **1 and 10**, where:
- 9–10: exemplary, production-grade, well-maintained
- 7–8: solid, minor issues
- 5–6: mixed quality, notable concerns
- 3–4: fragile or poorly structured
- 1–2: critically deficient

Be honest. If information is missing or unclear, state that explicitly.
### Scores

Rate each subcategory from **1 (critically deficient) to 10 (exemplary)**:

| Subcategory | Score | Rationale |
|---|---|---|
| Code Quality | X/10 | ... |
| Test Coverage | X/10 | ... |
| Documentation | X/10 | ... |
| Architecture | X/10 | ... |
| Security | X/10 | ... |
| Dependency Management | X/10 | ... |
| CI/CD & Tooling | X/10 | ... |
| **Overall** | **X/10** | ... |

Scale: 9–10 exemplary · 7–8 solid · 5–6 mixed · 3–4 fragile · 1–2 critical

Be honest. If information is missing or unclear, state that explicitly. Omit subcategories that are not applicable.
5 changes: 1 addition & 4 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ The Copilot coding agent environment is automatically configured via official Gi

These files must exist on the default branch. The agent does not need to run any setup commands manually.

For DevContainers and Codespaces, the `.devcontainer/` configuration and `bootstrap.sh` handle setup automatically. See `docs/DEVCONTAINER.md` for details.
For DevContainers and Codespaces, the `.devcontainer/` configuration and `bootstrap.sh` handle setup automatically.

## Project Structure

Expand All @@ -133,7 +133,6 @@ For DevContainers and Codespaces, the `.devcontainer/` configuration and `bootst
- `assets/`: Static assets
- `book/`: Documentation source
- `docker/`: Docker configuration
- `presentation/`: Presentation slides
- `.rhiza/`: Rhiza-specific scripts and configurations

## Coding Standards
Expand Down Expand Up @@ -173,8 +172,6 @@ Agentic workflow files are Markdown files in `.github/workflows/` with
- `ci-doctor.md` — Automatic CI failure diagnosis
- `issue-triage.md` — Automatic issue classification and labeling

For more details, see `docs/GH_AW.md`.

## Key Files

- `Makefile`: Main entry point for tasks.
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install uv
uses: astral-sh/setup-uv@v8.0.0
with:
version: "0.11.2"
version: "0.11.6"

- name: Configure git auth for private packages
uses: ./.github/actions/configure-git-auth
Expand Down
84 changes: 0 additions & 84 deletions .github/workflows/renovate_rhiza_sync.yml

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/rhiza_book.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Install uv
uses: astral-sh/setup-uv@v8.0.0
with:
version: "0.11.2"
version: "0.11.6"

- name: Configure git auth for private packages
uses: ./.github/actions/configure-git-auth
Expand All @@ -68,7 +68,7 @@ jobs:
# This allows anyone to download the built documentation directly from
# GitHub Actions without needing to run a full local build.
- name: Upload book as workflow artifact
uses: actions/upload-artifact@v7.0.0
uses: actions/upload-artifact@v7.0.1
with:
name: book
path: _book/
Expand All @@ -77,7 +77,7 @@ jobs:
# Step 5b: Package all artifacts for GitHub Pages deployment
# This prepares the combined outputs for deployment by creating a single artifact
- name: Upload static files as artifact
uses: actions/upload-pages-artifact@v4.0.0 # Official GitHub Pages artifact upload action
uses: actions/upload-pages-artifact@v5.0.0 # Official GitHub Pages artifact upload action
with:
path: _book/ # Path to the directory containing all artifacts to deploy
Comment on lines +80 to 82
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

What are the breaking changes in actions/upload-pages-artifact v5?

💡 Result:

The breaking changes in actions/upload-pages-artifact v5 (tagged v5.0.0) primarily stem from updating its internal dependency on actions/upload-artifact from v4 to v7. This update ensures compatibility with Node.js 24 runners following the Node 20 deprecation. Key changes in v5: - Updates actions/upload-artifact to version 7 (via PR #139). - Adds a new input: include-hidden-files (default: false), allowing explicit inclusion of hidden files/directories (excludes .git and .github regardless). This builds on v4's change where hidden files were excluded by default. No explicit breaking changes are listed in the v5 release notes, but inheriting from upload-artifact v7 may introduce upstream breaking changes such as: - Node.js 24 runtime requirement (actions/upload-artifact v6+). - Potential ESM support and other artifact handling updates from intermediate versions (v5-v7 of upload-artifact). Users should ensure their runners support Node 24 and test workflows, especially if relying on hidden files or specific artifact behaviors. For hidden files, use the new input if needed. v4 had a potentially breaking change: hidden files (dotfiles) excluded by default.

Citations:


Major version bump for upload-pages-artifact requires Node.js 24+ runtime.

The upgrade from v4.0.0 to v5.0.0 introduces a breaking change: Node.js 24 runtime requirement (inherited from actions/upload-artifact v7). The current workflow usage (path: _book/) is compatible with v5, but ensure your runners are configured for Node.js 24.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/rhiza_book.yml around lines 80 - 82, The workflow now uses
actions/upload-pages-artifact@v5.0.0 which requires Node.js 24+; update the
workflow so the runner provides Node 24 before calling
actions/upload-pages-artifact (or pin the action back to v4). Specifically,
either insert actions/setup-node (e.g. actions/setup-node@v4) with node-version:
"24" prior to the step that uses actions/upload-pages-artifact@v5.0.0, or change
the step to actions/upload-pages-artifact@v4.x while keeping path: _book/
unchanged.


Expand Down
Loading
Loading