refactor: remove dead _resolve_external_base_url helper (2.1.2)#67
Merged
refactor: remove dead _resolve_external_base_url helper (2.1.2)#67
Conversation
Copilot review on upstream PR music-assistant/server#3834 flagged this helper as defined but never used — the live code path uses resolve_base_url from _smarthome_auto_create.py instead. Drop the dead helper to shrink maintenance surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copilot review on upstream PR music-assistant/server#3834 flagged
_resolve_external_base_urlinprovider/__init__.pyas defined but never called. The live code path (_run_auto_create_action) usesresolve_base_urlfrom_smarthome_auto_create.pyinstead.Drop the dead helper to shrink maintenance surface. No behaviour change.
Bumps to 2.1.2 so CI publishes a fresh wheel and the upstream PR auto-resyncs.
Test plan
pytest tests/— 226 passedruff check provider testsclean🤖 Generated with Claude Code