fix(presets): drop whitespace-only dropdown values + strip surrounding spaces#119
Merged
fix(presets): drop whitespace-only dropdown values + strip surrounding spaces#119
Conversation
…g spaces Copilot review on music-assistant/server#3606 (upstream sync of v3.4.0) flagged that parse_stored_presets only checked `isinstance(val, str) and val`, so a hand-edited JSON with " " as a value would propagate whitespace into the rotor seed (settingDiversity: ) and the server would 4xx. Treat whitespace-only strings as empty (and therefore skipped), and store the stripped form when the value is valid — keeps the seed builder on canonical values regardless of whether the user typed trailing spaces. Covered by a new parser test exercising both the whitespace-only drop and the leading/trailing strip. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Copilot review comment on music-assistant/server#3606 against the upstream sync of v3.4.0.
parse_stored_presetsvalidated optional dropdown fields withisinstance(val, str) and val, so a hand-edited JSON with a whitespace-only value (e.g." ") passed validation and propagated into the rotor seed — Yandex then rejectssettingDiversity:with a 4xx, silently losing the preset.Change
Strip whitespace before the empty-check, keep the stripped form when the value is valid. Whitespace-only → treated as empty → skipped. Leading/trailing spaces on a valid value → normalised to canonical.
Test plan
pytest— 255/255 (+1 new test intest_my_wave.py::test_get_user_wave_presets_drops_whitespace_only_valuesexercising both the whitespace-only drop and the leading/trailing strip)ruff check/mypy— clean🤖 Generated with Claude Code