ci(upstream-pr): rewrite provider.* imports in synced tests#45
Merged
ci(upstream-pr): rewrite provider.* imports in synced tests#45
Conversation
The upstream PR workflow rsyncs tests/ from the source provider repo
into tests/providers/${DOMAIN}/ without rewriting the import prefix,
so each run reverts the source-repo "from provider.X" style back into
MA-server tests (regression surfaced in PR 3746 for yandex_smarthome).
Mirror the sed step already present in reusable-sync-to-fork.yml so the
synced tests use from/patch paths of music_assistant.providers.${DOMAIN}.*.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrappers/upstream-pr.yml.j2) rsyncstests/from the source provider repo intotests/providers/${DOMAIN}/without rewriting the import prefix.from provider.Xstyle back into MA-server tests, re-breaking manually-fixed imports.yandex_smarthome: the v1.3.0 sync commit introduced a second commit that replacedmusic_assistant.providers.yandex_smarthome.*withprovider.*in six test files.reusable-sync-to-fork.ymlso synced tests usemusic_assistant.providers.${DOMAIN}.*paths for bothfromimports andmock.patchstring literals.Test plan
Submit Provider to Upstreamworkflow for any provider with a pending release — verify the resulting commit onupstream/<domain>does not containfrom provider.or"provider.intests/providers/<domain>/*.py.reusable-sync-to-fork.ymlbehavior is unchanged (this PR only touchesupstream-pr.yml.j2).🤖 Generated with Claude Code