Remove hotfix for Static.jl#2978
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
|
StaticArrayInterface.jl also needs to be fixed before: https://github.com/JuliaArrays/StaticArrayInterface.jl/blob/c4087d811bdce4fe265b507b76ee6c8645f9a30f/src/stridelayout.jl#L438C14-L438C52 😬 . I'll submit a PR there. Edit: JuliaArrays/StaticArrayInterface.jl#52 |
ranocha
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me and can be merged when CI passes (waiting for JuliaRegistries/General#154292).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
+ Coverage 97.11% 97.13% +0.02%
==========================================
Files 624 624
Lines 48439 48439
==========================================
+ Hits 47039 47050 +11
+ Misses 1400 1389 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we get a force-merge here? CI is super slow right now. The macOS MPI CI job didn't even start for almost 2 hours now. The failing test is also only due to some network issues. |
StrideArraysCore.jl released a new version, which should make Static.jl v1.4 working again.
Closes #2977.