Skip to content

Remove hotfix for Static.jl#2978

Merged
JoshuaLampert merged 2 commits intomainfrom
remove-hotfix-static-jl
Apr 29, 2026
Merged

Remove hotfix for Static.jl#2978
JoshuaLampert merged 2 commits intomainfrom
remove-hotfix-static-jl

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

StrideArraysCore.jl released a new version, which should make Static.jl v1.4 working again.
Closes #2977.

@github-actions
Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@JoshuaLampert
Copy link
Copy Markdown
Member Author

JoshuaLampert commented Apr 29, 2026

@ranocha ranocha added bug Something isn't working upstream testing labels Apr 29, 2026
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me and can be merged when CI passes (waiting for JuliaRegistries/General#154292).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (fa762b2) to head (11a0174).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
+ Coverage   97.11%   97.13%   +0.02%     
==========================================
  Files         624      624              
  Lines       48439    48439              
==========================================
+ Hits        47039    47050      +11     
+ Misses       1400     1389      -11     
Flag Coverage Δ
unittests 97.13% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert JoshuaLampert enabled auto-merge (squash) April 29, 2026 13:51
@JoshuaLampert
Copy link
Copy Markdown
Member Author

Can we get a force-merge here? CI is super slow right now. The macOS MPI CI job didn't even start for almost 2 hours now. The failing test is also only due to some network issues.

@JoshuaLampert JoshuaLampert merged commit 5a0811f into main Apr 29, 2026
68 of 69 checks passed
@JoshuaLampert JoshuaLampert deleted the remove-hotfix-static-jl branch April 29, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hotfix related to newer versions of Static.jl

2 participants