CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#2918
CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#2918github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
39b92f8 to
61dc2aa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 612 612
Lines 47668 47668
=======================================
Hits 46277 46277
Misses 1391 1391
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoshuaLampert
left a comment
There was a problem hiding this comment.
Should be done in #2910.
|
Courtesy note from the SciMLBase v3 ecosystem sweep: this PR is a compat-only bump but Trixi has a non-trivial v3 surface area to check before merging. 22
SciMLBase v3 renamed Suggested pattern (same one used in SciML/DiffEqCallbacks.jl#300): replace direct imports with an @static if isdefined(SciMLBase, :derivative_discontinuity!)
using SciMLBase: derivative_discontinuity!
else
const derivative_discontinuity! = SciMLBase.u_modified!
endFor method definitions on Trixi integrator types, keep the existing Resolution caveat: CI will currently fail at Other v3 flags in Trixi src/test came up clean: no |
This pull request changes the compat entry for the
SciMLBasepackage from2.128to2.128, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.