Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
4a12427
CompatHelper: bump compat for RecursiveArrayTools to 4, (keep existin…
Apr 2, 2026
86f227a
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 9, 2026
4400e5b
allow SciMLBase.jl v3
JoshuaLampert Apr 9, 2026
f4f80d4
fix merge conflict
JoshuaLampert Apr 9, 2026
c3c88f5
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 22, 2026
56a1d36
allow DiffEqBase.jl v7
JoshuaLampert Apr 22, 2026
7cc7d89
allow OrdinaryDiffEqCore.jl v4
JoshuaLampert Apr 22, 2026
aa07005
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 27, 2026
0eed249
allow v2 of all OrdinaryDiffEq*.jl packages
JoshuaLampert Apr 27, 2026
39e7934
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 28, 2026
f6d8801
replace u_modified! by derivative_discontinuity!
JoshuaLampert Apr 28, 2026
9d03133
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 28, 2026
c024d02
ignore :derivative_discontinuity! for stale explicit imports
JoshuaLampert Apr 28, 2026
a3eaadc
move import
JoshuaLampert Apr 28, 2026
5cf52b9
import SciMLBase
JoshuaLampert Apr 28, 2026
a2a74df
import instead of using
JoshuaLampert Apr 28, 2026
5e91ab6
adapt to new controller interface
JoshuaLampert Apr 28, 2026
8fc1e81
restrict Static.jl to fix tests
JoshuaLampert Apr 28, 2026
eaad1ac
print controller instead of cache in SummaryCallback
JoshuaLampert Apr 28, 2026
f81faf1
stage limiter as keyword arguments
JoshuaLampert Apr 29, 2026
caf84a3
fix iterating over VectorOfArray
JoshuaLampert Apr 29, 2026
8b66f58
use Threaded() instead of True() for threads
JoshuaLampert Apr 29, 2026
ae96778
fix
JoshuaLampert Apr 29, 2026
e3b77c0
Update examples/tree_1d_dgsem/elixir_euler_density_wave_adaptive_vol_…
JoshuaLampert Apr 29, 2026
834f75f
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 29, 2026
f3d0353
make thread backwards compatible
JoshuaLampert Apr 29, 2026
fc20979
Merge branch 'compathelper/new_version/2026-04-02-00-09-29-812-040179…
JoshuaLampert Apr 29, 2026
bced723
fix stage limiter kwarg in docs
JoshuaLampert Apr 29, 2026
e1c0890
fix destats->stats in docs
JoshuaLampert Apr 29, 2026
1ff757c
fix another stage limiter in the docs
JoshuaLampert Apr 29, 2026
b3a5e10
make controller in SummaryCallback backwards compatible
JoshuaLampert Apr 29, 2026
0e08dd9
Update src/callbacks_step/summary.jl
JoshuaLampert Apr 29, 2026
8f19f85
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 29, 2026
b10d7ae
port #2773
JoshuaLampert Apr 29, 2026
5bcae97
add compat
JoshuaLampert Apr 29, 2026
6d57637
rename extension
JoshuaLampert Apr 29, 2026
4aba93f
fix obtaining controller
JoshuaLampert Apr 29, 2026
f9b4ff7
remove qold
JoshuaLampert Apr 29, 2026
d56c29d
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 29, 2026
8013d04
also save `dt_factor`
JoshuaLampert Apr 29, 2026
7790e6a
allow OrdinaryDiffEqLowStorageRK.jl v3 in docs
JoshuaLampert Apr 30, 2026
3d13e7c
set qsteady_max to 1.0
JoshuaLampert Apr 30, 2026
f99460e
Merge branch 'main' into compathelper/new_version/2026-04-02-00-09-29…
JoshuaLampert Apr 30, 2026
e66834d
get qsteady_max from ode algorithm
JoshuaLampert Apr 30, 2026
b54a42a
use other constructor of PIDController
JoshuaLampert May 1, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Convex = "f65535da-76fb-5f13-bab9-19810c17039a"
ECOS = "e2685f51-7e38-5353-a97d-a921fd2c8199"
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
SparseConnectivityTracer = "9f842d2f-2579-4b1d-911e-f412cf18a3f5"

Expand All @@ -70,6 +71,7 @@ TrixiConvexECOSExt = ["Convex", "ECOS"]
TrixiMakieExt = "Makie"
TrixiNLsolveExt = "NLsolve"
TrixiPlotsExt = "Plots"
TrixiOrdinaryDiffEqCoreExt = "OrdinaryDiffEqCore"
TrixiSparseConnectivityTracerExt = "SparseConnectivityTracer"

[compat]
Expand All @@ -83,7 +85,7 @@ ConstructionBase = "1.5.8"
Convex = "0.16"
DataStructures = "0.18.15, 0.19"
DelimitedFiles = "1"
DiffEqBase = "6.184"
DiffEqBase = "6.184, 7"
DiffEqCallbacks = "2.35, 3, 4"
Downloads = "1.6"
ECOS = "1.1.2"
Expand All @@ -101,16 +103,17 @@ MuladdMacro = "0.2.4"
NLsolve = "4.5.1"
Octavian = "0.3.28"
OffsetArrays = "1.13"
OrdinaryDiffEqCore = "1.26, 2, 3, 4"
P4est = "0.4.12"
Plots = "1.38.13"
Polyester = "=0.7.16, 0.7.18"
PrecompileTools = "1.2.1"
Preferences = "1.5"
Printf = "1"
RecipesBase = "1.3.4"
RecursiveArrayTools = "3.37"
RecursiveArrayTools = "3.37, 4"
Reexport = "1.2.2"
SciMLBase = "2.128"
SciMLBase = "2.128, 3"
SimpleUnPack = "1.1"
SparseArrays = "1"
SparseConnectivityTracer = "1.0.1"
Expand Down
2 changes: 1 addition & 1 deletion benchmark/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ Trixi = "a7f1ee26-1774-49b1-8366-f1abc58fbfcb"

[compat]
BenchmarkTools = "0.5, 0.7, 1.0"
OrdinaryDiffEq = "5.65, 6"
OrdinaryDiffEq = "5.65, 6, 7"
PkgBenchmark = "0.2.10"
Trixi = "0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16"
10 changes: 5 additions & 5 deletions docs/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ LaTeXStrings = "1.2"
Literate = "2.9"
Measurements = "2.5"
NLsolve = "4.5.1"
OrdinaryDiffEqLowOrderRK = "1.2"
OrdinaryDiffEqLowStorageRK = "1.2"
OrdinaryDiffEqSDIRK = "1.1"
OrdinaryDiffEqSSPRK = "1.2"
OrdinaryDiffEqTsit5 = "1.1"
OrdinaryDiffEqLowOrderRK = "1.2, 2"
OrdinaryDiffEqLowStorageRK = "1.2, 2, 3"
OrdinaryDiffEqSDIRK = "1.1, 2"
OrdinaryDiffEqSSPRK = "1.2, 2"
OrdinaryDiffEqTsit5 = "1.1, 2"
Plots = "1.9"
SparseConnectivityTracer = "1.0.1"
SparseMatrixColorings = "0.4.21"
Expand Down
10 changes: 5 additions & 5 deletions docs/literate/src/files/adding_new_parabolic_terms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ callbacks = CallbackSet(SummaryCallback())
time_int_tol = 1.0e-6
sol = solve(ode, RDPK3SpFSAL49(); abstol = time_int_tol, reltol = time_int_tol,
ode_default_options()..., callback = callbacks);
println("Number of timesteps: ", sol.destats.naccept)
println("Number of timesteps: ", sol.stats.naccept)

using Plots
plot(sol)
Expand All @@ -179,9 +179,9 @@ plot(sol)

# In the example above, we used an adaptive timestep based on truncation error estimates.
# Alternatively, we can also use a CFL-based timestep control, cf. [`StepsizeCallback`](@ref).
# To be able to do so, we need to define [`max_diffusivity`](@ref) and
# To be able to do so, we need to define [`max_diffusivity`](@ref) and
# [`have_constant_diffusivity`](@ref) for the new parabolic terms.
# In Trixi.jl, currently only the standard Laplace Diffusion and Compressible Navier-Stokes-Fourier
# In Trixi.jl, currently only the standard Laplace Diffusion and Compressible Navier-Stokes-Fourier
# parabolic terms are implemented.
# Since these equations have **isotropic** diffusivity, i.e., direction-independent coefficients,
# [`max_diffusivity`](@ref) is expected to return a scalar value.
Expand All @@ -198,7 +198,7 @@ lambda_max() = maximum(abs.(eigvals(diffusivity)))
return Trixi.True()
end

# Return the estimated maximum diffusivity for CFL calculations based on
# Return the estimated maximum diffusivity for CFL calculations based on
# the spectral radius of the diffusivity matrix computed above
@inline function Trixi.max_diffusivity(equations_parabolic::ConstantAnisotropicDiffusion2D)
return lambda_max()
Expand All @@ -216,7 +216,7 @@ callbacks = CallbackSet(SummaryCallback(), stepsize_callback);
sol = solve(ode, RDPK3SpFSAL49();
adaptive = false, dt = stepsize_callback(ode),
ode_default_options()..., callback = callbacks);
println("Number of timesteps: ", sol.destats.naccept)
println("Number of timesteps: ", sol.stats.naccept)

plot(sol)

Expand Down
6 changes: 3 additions & 3 deletions docs/literate/src/files/shock_capturing.jl
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
# ````
# Then, the limiter is added to the time integration method in the `solve` function. For instance, like
# ````julia
# CarpenterKennedy2N54(stage_limiter!, williamson_condition=false)
# CarpenterKennedy2N54(; stage_limiter!, williamson_condition=false)
# ````
# or
# ````julia
Expand Down Expand Up @@ -229,7 +229,7 @@ callbacks = CallbackSet(analysis_callback, stepsize_callback);
stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-6),
variables = (Trixi.density, pressure))

sol = solve(ode, CarpenterKennedy2N54(stage_limiter!, williamson_condition = false);
sol = solve(ode, CarpenterKennedy2N54(; stage_limiter!, williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);

Expand Down Expand Up @@ -363,7 +363,7 @@ callbacks = CallbackSet(summary_callback,
stage_limiter! = EntropyBoundedLimiter()

# We run the simulation with the SSPRK33 method and the entropy bounded limiter:
sol = solve(ode, SSPRK33(stage_limiter!);
sol = solve(ode, SSPRK33(; stage_limiter!);
dt = 1.0,
callback = callbacks);

Expand Down
2 changes: 1 addition & 1 deletion docs/src/parallelization.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ the same time, the latter takes precedence.
If you use time integration methods from
[OrdinaryDiffEq.jl](https://github.com/SciML/OrdinaryDiffEq.jl)
and want to use multiple threads therein, you need to set the keyword argument
`thread = Trixi.True()` (or `thread = OrdinaryDiffEq.True()`)
`thread = Trixi.Threaded()`
of the algorithms, as described in the
[section on time integration methods](@ref time-integration).

Expand Down
6 changes: 3 additions & 3 deletions docs/src/time_integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ are the following. Further documentation can be found in the
from Trixi.jl.
- If you start Julia with multiple threads and want to use them also in the time
integration method from OrdinaryDiffEq.jl, you need to pass the keyword argument
`thread = Trixi.True()` (or `thread = OrdinaryDiffEq.True()`) to the algorithm, e.g.,
`RDPK3SpFSAL49(thread = Trixi.True())` or
`CarpenterKennedy2N54(thread = Trixi.True(), williamson_condition = false)`.
`thread = Trixi.Threaded()` to the algorithm, e.g.,
`RDPK3SpFSAL49(thread = Trixi.Threaded())` or
`CarpenterKennedy2N54(thread = Trixi.Threaded(), williamson_condition = false)`.
For more information on using thread-based parallelism in Trixi.jl, please refer to
[Shared-memory parallelization with threads](@ref).
- If you use error-based step size control (see also the section on
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,6 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback,

###############################################################################
# run the simulation
sol = solve(ode, SSPRK54(thread = Trixi.True());
sol = solve(ode, SSPRK54(thread = Trixi.Threaded());
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ callbacks = CallbackSet(summary_callback,

# Run the simulation
###############################################################################
sol = solve(ode, SSPRK104(; thread = Trixi.True());
sol = solve(ode, SSPRK104(; thread = Trixi.Threaded());
dt = 1.0, # overwritten by the `stepsize_callback`
ode_default_options()...,
callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-
###############################################################################
# Run the simulation

sol = solve(ode, SSPRK33(stage_limiter! = stage_limiter!, thread = Trixi.True());
sol = solve(ode, SSPRK33(; stage_limiter! = stage_limiter!, thread = Trixi.Threaded());
dt = 1.6e-5, # Fixed timestep works decent here
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_2d_dgsem/elixir_euler_double_mach_amr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -154,5 +154,5 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-

###############################################################################
# run the simulation
sol = solve(ode, SSPRK43(stage_limiter!);
sol = solve(ode, SSPRK43(; stage_limiter!);
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-

###############################################################################
# run the simulation
sol = solve(ode, SSPRK43(stage_limiter! = stage_limiter!, thread = Trixi.True());
sol = solve(ode, SSPRK43(; stage_limiter! = stage_limiter!, thread = Trixi.Threaded());
dt = 5e-7, # Reducing initial timestep allows AMR interval of 2 instead of 1
adaptive = true, ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_2d_dgsem/elixir_euler_forward_step_amr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-

###############################################################################
# run the simulation
sol = solve(ode, SSPRK43(stage_limiter!);
sol = solve(ode, SSPRK43(; stage_limiter!);
maxiters = 999999, ode_default_options()...,
callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ callbacks = CallbackSet(summary_callback,
# run the simulation

time_int_tol = 1e-6
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = time_int_tol, reltol = time_int_tol,
adaptive = true, dt = 1e-3, # needed only for tests/CI
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_2d_dgsem/elixir_euler_subsonic_cylinder.jl
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback, sav
# run the simulation
sol = solve(ode,
CarpenterKennedy2N54(williamson_condition = false;
thread = Trixi.True());
thread = Trixi.Threaded());
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,5 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-7, 1.0e-

###############################################################################
# run the simulation
sol = solve(ode, SSPRK43(stage_limiter!);
sol = solve(ode, SSPRK43(; stage_limiter!);
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-7, 1.0e-
# We supply a small initial timestep to be able to use a larger AMR interval (3 instead of 1) throughout the simulation.
# This pays off almost immediately as only the first couple timesteps use this timestep before it is ramped up.
dt0 = 1e-8
sol = solve(ode, SSPRK43(stage_limiter! = stage_limiter!, thread = Trixi.True());
sol = solve(ode, SSPRK43(; stage_limiter! = stage_limiter!, thread = Trixi.Threaded());
adaptive = true, dt = dt0,
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_2d_dgsem/elixir_mhd_rotor_cfl_ramp.jl
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ callbacks = CallbackSet(summary_callback,
# run the simulation

sol = solve(ode,
CarpenterKennedy2N54(thread = Trixi.True(),
CarpenterKennedy2N54(thread = Trixi.Threaded(),
williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,6 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback, sav
###############################################################################
# run the simulation

sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = 1e-8, reltol = 1e-8,
ode_default_options()..., callback = callbacks)
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,6 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback,

###############################################################################

sol = solve(ode, SSPRK54(thread = Trixi.True());
sol = solve(ode, SSPRK54(thread = Trixi.Threaded());
dt = dt_restart,
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ callbacks = CallbackSet(summary_callback,
###############################################################################
# run the simulation

ode_algorithm = SSPRK43(thread = Trixi.True())
ode_algorithm = SSPRK43(thread = Trixi.Threaded())

time_int_tol = 1e-4
sol = solve(ode, ode_algorithm;
abstol = time_int_tol, reltol = time_int_tol, dt = 1e-6,
maxiters = Inf, # long simulation
controller = PIDController(0.55, -0.27, 0.05), # optimized for SSPRK43
controller = PIDController(ode_algorithm, beta = (0.55, -0.27, 0.05)), # optimized for SSPRK43
ode_default_options()..., callback = callbacks)
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,5 @@ callbacks = CallbackSet(summary_callback,

sol = solve(ode,
CarpenterKennedy2N54(williamson_condition = false,
thread = Trixi.True());
thread = Trixi.Threaded());
dt = 1.0, ode_default_options()..., callback = callbacks)
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ callbacks = CallbackSet(summary_callback,
# run the simulation

# Moderate number of threads (e.g. 4) advisable to speed things up
ode_alg = RDPK3SpFSAL49(thread = Trixi.True())
ode_alg = RDPK3SpFSAL49(thread = Trixi.Threaded())
time_int_tol = 1e-7
sol = solve(ode, ode_alg;
# not necessary, added for overwriting in tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,6 @@ callbacks = CallbackSet(summary_callback,

# Use a Runge-Kutta method with automatic (error based) time step size control
# Enable threading of the RK method for better performance on multiple threads
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = 1.0e-6, reltol = 1.0e-6,
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,6 @@ callbacks = CallbackSet(summary_callback,

# Use a Runge-Kutta method with automatic (error based) time step size control
# Enable threading of the RK method for better performance on multiple threads
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = 1.0e-6, reltol = 1.0e-6,
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_3d_dgsem/elixir_euler_tandem_spheres.jl
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,6 @@ callbacks = CallbackSet(summary_callback,
###############################################################################

tols = 1e-5
sol = solve(ode, RDPK3SpFSAL35(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL35(thread = Trixi.Threaded());
abstol = tols, reltol = tols,
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/p4est_3d_dgsem/elixir_mhd_amr_entropy_bounded.jl
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,6 @@ stage_limiter! = EntropyBoundedLimiter(exp_entropy_decrease_max = -5e-3)
###############################################################################
# run the simulation

sol = solve(ode, CarpenterKennedy2N54(stage_limiter!, williamson_condition = false);
sol = solve(ode, CarpenterKennedy2N54(; stage_limiter!, williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,6 @@ callbacks = CallbackSet(summary_callback,
# run the simulation

time_int_tol = 1e-8
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = time_int_tol, reltol = time_int_tol,
ode_default_options()..., callback = callbacks)
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (1.0e-4, 1.0e-
###############################################################################
# run the simulation

sol = solve(ode, CarpenterKennedy2N54(stage_limiter!, williamson_condition = false);
sol = solve(ode, CarpenterKennedy2N54(; stage_limiter!, williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,6 @@ callbacks = CallbackSet(summary_callback,

# Use a Runge-Kutta method with automatic (error based) time step size control
# Enable threading of the RK method for better performance on multiple threads
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.True());
sol = solve(ode, RDPK3SpFSAL49(thread = Trixi.Threaded());
abstol = 1.0e-6, reltol = 1.0e-6,
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ stage_limiter! = EntropyBoundedLimiter()
###############################################################################
# run the simulation

sol = solve(ode, SSPRK33(stage_limiter!);
sol = solve(ode, SSPRK33(; stage_limiter!);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()...,
callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ callbacks = CallbackSet(summary_callback,
###############################################################################
# run the simulation

sol = solve(ode, CarpenterKennedy2N54(williamson_condition = false, thread = Trixi.True());
sol = solve(ode,
CarpenterKennedy2N54(williamson_condition = false, thread = Trixi.Threaded());
dt = stepsize_callback(ode),
ode_default_options()..., callback = callbacks);
2 changes: 1 addition & 1 deletion examples/tree_1d_dgsem/elixir_euler_modified_sod.jl
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ callbacks = CallbackSet(summary_callback,
stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-6),
variables = (Trixi.density, pressure))
ode_alg = SSPRK43(stage_limiter! = stage_limiter!)
ode_alg = SSPRK43(; stage_limiter! = stage_limiter!)
=#
# Flux-differencing volume integral does not require positivity preservation for this test case.
ode_alg = SSPRK43()
Expand Down
2 changes: 1 addition & 1 deletion examples/tree_1d_dgsem/elixir_euler_positivity.jl
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,6 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6, 5.0e-
###############################################################################
# run the simulation

sol = solve(ode, CarpenterKennedy2N54(stage_limiter!, williamson_condition = false);
sol = solve(ode, CarpenterKennedy2N54(; stage_limiter!, williamson_condition = false);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,6 @@ callbacks = CallbackSet(summary_callback,
stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-6,),
variables = (pressure,))

sol = solve(ode, SSPRK54(stage_limiter! = stage_limiter!);
sol = solve(ode, SSPRK54(; stage_limiter! = stage_limiter!);
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
ode_default_options()..., callback = callbacks);
Loading
Loading