fix: * operator after .. incorrectly parsed as binary#305
Open
Strawbang wants to merge 1 commit intotree-sitter:masterfrom
Open
fix: * operator after .. incorrectly parsed as binary#305Strawbang wants to merge 1 commit intotree-sitter:masterfrom
Strawbang wants to merge 1 commit intotree-sitter:masterfrom
Conversation
* Fix shift/reduce conflict in range_expression so that `..*a` parses as a prefix range ending at a dereference, not as a binary multiplication of RangeFull by a * Add corpus test for range expressions with leading unary operators * Regenerate parser
|
Thanks for working on this! I have integrated it in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
..*awas incorrectly parsed as(..) * a(binary multiply) instead of a prefix range ending at a dereference.This affects real code like Tokio's
buf_writer.rs:The fix gives the prefix range alternative
seq('..', $._expression)a slightly higher precedence (PREC.range + 1) with right-associativity, so the parser prefers building the range's right side over reducing `..\ to astandalone RangeFull when followed by a unary operator.