Skip to content

Support for attributes inside struct patterns and turbofish notation with struct patterns#301

Open
vanessa-rodrigues wants to merge 1 commit intotree-sitter:masterfrom
vanessa-rodrigues:dev/structPatterns
Open

Support for attributes inside struct patterns and turbofish notation with struct patterns#301
vanessa-rodrigues wants to merge 1 commit intotree-sitter:masterfrom
vanessa-rodrigues:dev/structPatterns

Conversation

@vanessa-rodrigues
Copy link
Copy Markdown
Contributor

(+) Added argument field in type_arguments rule.

@wetneb
Copy link
Copy Markdown

wetneb commented Feb 13, 2026

Hi @vanessa-rodrigues,
Thanks for working on this!
I looked into porting your changes to tree-sitter-rust-orchard (as I do it for all PRs opened on this repo) and it turns out that both the support for attributes and the turbofish notation are already included. The argument field to type_arguments isn't implemented yet but that would be an easy thing to do. But I imagine that switching to the fork is perhaps not an option for you? If there is anything I can address there, let me know.

@vanessa-rodrigues
Copy link
Copy Markdown
Contributor Author

Hi @wetneb, thanks for sharing the fork link, and sorry for the late reply! I was just wondering why the changes wouldn’t be merged directly here — just trying to understand.

@wetneb
Copy link
Copy Markdown

wetneb commented Mar 3, 2026

I have submitted them here (#269) about a year ago. I personally don't have merge rights in this repository, so that's all I can do. From the state of the pull requests of this repository (where many more useful contributions are waiting) I deduce that this project isn't actively maintained.

Quite a few grammars in this organization are in the same state: good contributions not being integrated because nobody has simultaneously the time and the rights to accept them. My impression is that among the people who are active in the tree-sitter GitHub org, people don't want to, or don't feel legitimate to invite new maintainers to those repositories.

I am not aware of any documented governance for this project, and some see @maxbrunsfeld as the only person with the authority to invite new maintainers (but he is busy on other fronts). I have reached out to @maxbrunsfeld by email on this topic some months ago but didn't get a reply.

That's why I started the grammar orchard, to offer a space where collective maintenance of tree-sitter parsers can happen (the "tree-sitter-grammars" org would also be a possibility, but they don't seem to accept new members or repositories).

If it becomes possible again to collaborate on this repository, I would be delighted to do so. I would also be happy to assist with drafting governance for the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants