disabled ssl for enterprise

[Tahsin-travis-ci]

Objective:

• disable ssl for enterprise as it will be internal communication

[eugene-travis]

it is a diffent file, but @config is a class attribute

[Tahsin-travis-ci]

it is a diffent file, but @config is a class attribute

BaseAuth class has it's own config method. we are not using BaseAuth class on config.ru.

[eugene-travis]

Calling auth module looks weird of course. Looks like a bigger refactoring is needed here as Sven told me that config should be initialized just once

[GbArc]

ok for current needs

[svenfuchs]

fwiw, just for future reference (no action needed, i'll clean these up myself)

• travis-config picks up env vars named TRAVIS_[key-defined-as-default]
• methods returning booleans commonly are not named is_[name] but [name]? in Ruby

put together this is sufficient:

class Config < Travis::Config
      define enterprise: false,
             # ...
end

and then:

use Rack::SslEnforcer unless config.enterprise?

can be quickly tested like this, too:

>> require 'travis/yml'
=> true
>> Travis::Yml.config.enterprise?
=> false

$ TRAVIS_ENTERPRISE=true bundle exec irb
>> require 'travis/yml'
=> true
>> Travis::Yml.config.enterprise?
=> true

[Tahsin-travis-ci]

@svenfuchs Thanks for your suggestion. I will follow it in future. I modified the code accordingly in a separate PR #146