Skip to content

Fix typos in fastsync comments #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
podviaznikov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typos in fastsync comments #984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef16720
fix typos
podviaznikov Jul 1, 2022
5416f9d
Merge branch 'master' into patch-1
amofakhar Jan 9, 2025
a7bdc18
Merge branch 'master' into patch-1
crablab Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pipelinewise/fastsync/commons/split_gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
DEFAULT_MAX_CHUNKS = 20

# Detecting compressed file size at write time is not possible by GzipFile.
# The data hase to be written into the file first before the actual compression performed.
# The data has to be written into the file first before the actual compression performed.
# We need to use a good estimate for a text gzip file to split the file at write time.
EST_COMPR_RATE = 0.12

Expand All @@ -34,7 +34,7 @@ def open(
max_chunks: Max number of chunks. If set to 0 then splitting is disabled and one single
file will be created (Default: 20)
est_compr_rate: Detecting compressed file size at write time is not possible by GzipFile.
The data hase to be written into the file first before the actual compression performed.
The data has to be written into the file first before the actual compression performed.
We need to use a good estimate for a text gzip file to split the file at write time.
(Default 0.12)

Expand Down
Loading