Skip to content

Add support for Postgres' hstore type to fast sync#948

Open
Tolsto wants to merge 1 commit intotransferwise:masterfrom
Tolsto:fastsync-hstore-support
Open

Add support for Postgres' hstore type to fast sync#948
Tolsto wants to merge 1 commit intotransferwise:masterfrom
Tolsto:fastsync-hstore-support

Conversation

@Tolsto
Copy link
Copy Markdown
Contributor

@Tolsto Tolsto commented Apr 19, 2022

Problem

Fast sync would map an hstore type to VARCHAR in Snowflake. However, log-based replication would then migrate the column to VARIANT during the first run.

Proposed changes

Serialize hstore as json and create column of type VARIANT in Snowflake.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Fast sync would map an hstore type to VARCHAR in Snowflake. However, that log based replication would then migrate the column to VARIANT during the first run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant