Overload HASH transfrom to cheat checks#914
Open
Jonathan-Poelhuis wants to merge 1 commit intotransferwise:masterfrom
Open
Overload HASH transfrom to cheat checks#914Jonathan-Poelhuis wants to merge 1 commit intotransferwise:masterfrom
Jonathan-Poelhuis wants to merge 1 commit intotransferwise:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took an easy route, and (using the idea of Damien) overloaded the HASH transform to get past
pipelinewisestrict hard-coded checking (that also relies on another external package.) Different from Damien's approach, I wrote the new transforms in thetransform_utils.pyrather than try an "import a package of our own" approach. It's less snappy but potentially simpler.To make this work, I
external_typeandparamto thetap.jsonschemaconfig.py(including levels when they're missing)ExternalTransformationTypeEnum, including valid levels for when the parameters are not givenTransformationType.HASHto have a switch when anexternal_typeis given.