Refactor for wgpu v23 compatibility#2435
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main tracel-ai/burn#2435 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 833 833
Lines 106449 106448 -1
=======================================
Hits 87146 87146
+ Misses 19303 19302 -1 ☔ View full report in Codecov by Sentry. |
* The comments in `WgpuDevice::id()` are removed since `id` in `WgpuDevice::Existing` is always `u32`
DiscoveryThe least recent version of |
This comment has been minimized.
This comment has been minimized.
Status UpdateCurrently, I am busy working at my personal projects. I would run CI every one or two weeks. It seems that there are more errors occurred on macOS. I would resolve them after I finish my own works. |
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
That's awesome! Thanks for checking again :) I think the remaining errors are the same as here: #2539 The deformable convolutions might need some attention from Genna, for the others, maybe @nathanielsimard knows? |
994373b to
43b6d32
Compare
43b6d32 to
1d8b131
Compare
|
It just passed CI 20 hours ago ... And macOS failed at 110+ tests? I think I am using the right CubeCL version. |
|
I think we updated to the newly updated CubeCL with wgpu v23, so this PR is no longer necessary, thanks for your help on the update 🙏 |
Checklist
run-checks allscript has been executed.contributor-book/src/guides/adding-a-new-operation-to-burn.mdneeds to be updated.Related Issues/PRs
Close tracel-ai/cubecl#1167
Changes
cubeclto tracel-ai/cubecl@13fc62cwgputo23.0.0WgpuDevice::id()inburn-tensorTesting
(Solved): I run
./run-checks.sh all, but too many errors occurred on macOS (Metal) 🥺. Fixing the bugs ...