You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
crypto/common/bitstring.h:513: operator=(ConstBitPtr) now assigns through BitArray(from). For non-byte-aligned n, that constructor leaves the unused bits in the last byte uninitialized, then copies the whole std::array into *this. Previously assignment copied only n bits into existing storage, so a zeroed tail stayed zero. This can make as_slice()/as_array() expose nondeterministic tail bits after BitArray<15> x = BitArray<15>::zero(); x = ptr;. Keep the direct bits_memcpy assignment path or zero-initialize the temporary storage first.
crypto/common/bitstring.h:574: non-byte-aligned BitArrays lost relational ordering. The old operator< worked for every n, but the new <=> is only declared for n % 8 == 0, and compare() is not used for rewritten relational operators. Existing or downstream code using BitArray<15>/BitArray<267> in ordered comparisons or ordered containers will no longer have the same API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.