fix: plugin install integrity check + branch rules#201
fix: plugin install integrity check + branch rules#201github-actions[bot] merged 1 commit intodevelopfrom
Conversation
- Add cross-plugin overwrite protection: block install when archive contains a different plugin ID than requested AND would overwrite an existing plugin directory (prevents silent overwrites) - Allow mismatched slug/id when no existing plugin would be affected - Strengthen CLAUDE.md branch rules: explicit step-by-step workflow for Claude Code, explicit NEVER list Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughTwo changes are introduced: (1) CLAUDE.md updates branch protection rules from "Critical" to "MANDATORY" with stricter Git workflow requirements including explicit branch naming conventions and a prohibited actions list; (2) apps/desktop/src/main/index.ts modifies the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Addresses P1 review finding from PR #200 and strengthens git flow rules.
Plugin Install
(manifest.id ≠ requested slug), block only if it would overwrite an existing
plugin directory — prevents silent overwrites without blocking valid installs
where slug and manifest ID legitimately differ
CLAUDE.md
Test plan
pnpm typecheck— 17/17 pass🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation