Set up GitHub Actions CI#10
Merged
Merged
Conversation
taiki-e
commented
May 11, 2021
Comment on lines
+28
to
+30
| # TODO: Currently, valuable cannot build with targets that do not have atomic CAS. | ||
| # We should port https://github.com/rust-lang/futures-rs/pull/2400. | ||
| # - thumbv6m-none-eabi |
Member
Author
There was a problem hiding this comment.
The fix of this is in my other branch (be24a36), but it is bigger than this PR, so perhaps separate PR would be preferable.
taiki-e
commented
May 11, 2021
Comment on lines
+38
to
+39
| # TODO: Currently, valuable cannot build without `alloc` feature | ||
| # because `Debug` impl of `dyn Enumerable` uses `format!` macro. |
Member
Author
There was a problem hiding this comment.
This is mainly due to the following two lines.
valuable/valuable/src/enumerable.rs
Line 109 in 7640b04
valuable/valuable/src/enumerable.rs
Line 124 in 7640b04
@carllerche: Do you think it's ok to change it to print only variant name when alloc feature is disabled? (like the following)
#[cfg(feature = "alloc")]
let name = format!("{}::{}", self.name, variant.name());
#[cfg(not(feature = "alloc"))]
let name = variant.name();
Member
There was a problem hiding this comment.
yeah... we can probably tweak that. I'm fine w/ your proposal. Another PR 👍
carllerche
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8