fs(tests): improve io_uring tests#8134
Open
mattiapitossi wants to merge 5 commits intotokio-rs:masterfrom
Open
fs(tests): improve io_uring tests#8134mattiapitossi wants to merge 5 commits intotokio-rs:masterfrom
mattiapitossi wants to merge 5 commits intotokio-rs:masterfrom
Conversation
mattiapitossi
added
A-tokio
mattiapitossi
changed the title
…io into improve-io-uring-tests
mattiapitossi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we are running all fs tests in a Kernel version where io_uring is not supported to check if the fallback mechanism works. This comes with the limitation that each io_uring test cannot perform some checks (e.g., assert_pending).
I don't think it's necessary to check the fallback mechanism logic in every tests, so I was thinking to not run some tests where io_uring is not supported (or probably run it anyway and skip the assert pending check depending on the Kernel).
See also: #8080 (comment)
Solution
Introduce a check in some tests to see if io_uring is supported, otherwise skip the test. I was thinking that another solution would be probably to skip the tests if the kernel is <5.1, but probably the check if io_uring is supported it's better since it shows the intent and it's not hidden behind a filter in the CI.