Skip to content

Replace the internal implementation of LocalPoolHandle with LocalRuntime#7852

Open
Fodesu wants to merge 2 commits intotokio-rs:masterfrom
Fodesu:localpoolhandle
Open

Replace the internal implementation of LocalPoolHandle with LocalRuntime#7852
Fodesu wants to merge 2 commits intotokio-rs:masterfrom
Fodesu:localpoolhandle

Conversation

@Fodesu
Copy link
Copy Markdown

@Fodesu Fodesu commented Jan 12, 2026

Motivation

for Ref: #7560 #7558
wait LocalRuntime stabilization

Solution

use channel send work thread' LocalRuntime handle

@github-actions github-actions Bot added the R-loom-util Run loom tokio-util tests on this PR label Jan 12, 2026
@Fodesu Fodesu marked this pull request as draft January 12, 2026 13:48
@Fodesu
Copy link
Copy Markdown
Author

Fodesu commented Jan 12, 2026

should I use conditional compilation to fix CI issues, or wait for LocalRuntime to stabilize?

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-runtime Module: tokio/runtime labels Jan 12, 2026
@Darksonn
Copy link
Copy Markdown
Member

You can wait. This cannot be merged until stabilization anyway.

@martin-g
Copy link
Copy Markdown
Member

The stabilization of LocalRuntime is in progress - #7557 (comment)

@Darksonn
Copy link
Copy Markdown
Member

Darksonn commented Apr 4, 2026

If you still want to work on this, then you can do so now. LocalRuntime was stabilized in 1.51

@Fodesu Fodesu marked this pull request as ready for review April 19, 2026 11:37
Comment thread tokio-util/src/task/spawn_pinned.rs Outdated
@mattiapitossi mattiapitossi added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Apr 21, 2026
@Fodesu
Copy link
Copy Markdown
Author

Fodesu commented Apr 21, 2026

@mattiapitossi Could you rerun the CI / FreeBSD action?

@mattiapitossi
Copy link
Copy Markdown
Member

Done @Fodesu, you can also trigger the CI with an empty commit if you need. I’ll take a look on the error

@Fodesu
Copy link
Copy Markdown
Author

Fodesu commented Apr 21, 2026

Done @Fodesu, you can also trigger the CI with an empty commit if you need. I’ll take a look on the error

thanks

@Fodesu Fodesu requested a review from Darksonn April 22, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio-util Area: The tokio-util crate M-runtime Module: tokio/runtime R-loom-util Run loom tokio-util tests on this PR S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants