ci: upgrade to new nightly#4268
Merged
Merged
Conversation
As of the latest nightly, this is a warning by default and we deny doc warnings on CI. Refs: https://doc.rust-lang.org/rustdoc/lints.html#broken_intra_doc_links
Darksonn
reviewed
Nov 23, 2021
Comment on lines
-19
to
-22
| #![cfg_attr(docsrs, feature(doc_cfg_hide))] | ||
| #![cfg_attr(docsrs, doc(cfg_hide(docsrs)))] | ||
| #![cfg_attr(docsrs, doc(cfg_hide(loom)))] | ||
| #![cfg_attr(docsrs, doc(cfg_hide(not(loom))))] |
Member
There was a problem hiding this comment.
Have you verified that the documentation still looks alright after removing these?
Member
Author
There was a problem hiding this comment.
Yes
nightly-2021-11-23, on taiki-e/doc_cfg branch:
cd tokio
RUSTDOCFLAGS='--cfg docsrs' cargo +nightly-2021-11-23 doc --all-features --open
nightly-2021-10-25, on taiki-e/doc_cfg branch:
cd tokio
RUSTDOCFLAGS='--cfg docsrs' cargo +nightly-2021-10-25 doc --all-features --open
EDIT: The first image I posted had the date reversed.
Darksonn
reviewed
Nov 23, 2021
| feature = "process", | ||
| all(unix, feature = "signal"), | ||
| ))] | ||
| #[cfg_attr(docsrs, doc(cfg(all())))] |
Member
Author
There was a problem hiding this comment.
nightly-2021-11-23:
nightly-2021-10-25:
Darksonn
added
A-ci
Darksonn
approved these changes
Nov 23, 2021
Member
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
Assuming that the docs still look good, this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The behavior introduced in rust-lang/rust#89596 (auto doc_cfg) is now split to another feature flag (rust-lang/rust#90502).
We can remove some changes done in #4193.