Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@ resolver = "2"
members = [
"crates/weaver-core",
"crates/weaver-interface",
"crates/weaver-inference",
"crates/weaver-database",
"crates/weaver-demo",
"crates/weaver-trace",
"crates/weaver-analysis",
"crates/weaver-embedding",
"crates/weaver-spu",
]

Expand All @@ -23,8 +21,10 @@ license = "Apache-2.0"
weaver-core = { path = "crates/weaver-core" }
weaver-trace = { path = "crates/weaver-trace" }
weaver-analysis = { path = "crates/weaver-analysis" }
weaver-embedding = { path = "crates/weaver-embedding" }
weaver-inference = { path = "crates/weaver-inference" }
# `weaver-embedding` and `weaver-inference` were deprecated re-export
# shells removed in PR-0.5.E. Their content folded into `weaver-spu`
# (encoder + decoder runtime) and `weaver-core` (Embedder trait).
# Workspace member count contracted from 9 → 7 per spec §6.
# `default-features = false` at the workspace level so consumers can
# explicitly opt out of weaver-spu's default feature set without
# tripping cargo's "can't override workspace defaults" rule. Today
Expand Down
2 changes: 1 addition & 1 deletion crates/weaver-core/src/embedder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ impl From<tonic::Status> for EmbeddingError {
/// Backend-agnostic embedding service.
///
/// Implementations:
/// - `weaver_embedding::grpc_client::EmbeddingClient` — Python service over
/// - `weaver_spu::encoder::grpc_client_legacy::EmbeddingClient` — Python service over
/// Unix socket / TCP gRPC (pre-Phase-1 cutover).
/// - `weaver_spu::encoder::client::EmbedderClient` — Rust in-process
Comment thread
coderabbitai[bot] marked this conversation as resolved.
/// candle backend (post-Phase-1 cutover).
Expand Down
2 changes: 1 addition & 1 deletion crates/weaver-database/src/chunking/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
//! belongs alongside the rest of the embedding pipeline. Consumers
//! that need `LateChunkConfig` / `LateChunkResult` /
//! `late_chunk_embeddings` import from
//! `weaver_embedding::late_chunk::*` instead.
//! `weaver_spu::encoder::late_chunk::*` instead.

mod strategies;

Expand Down
2 changes: 1 addition & 1 deletion crates/weaver-database/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub mod graph;
// `weaver-embedding::grpc_client` per
// `embedder-oxidization-Spec.md` §5.1 (issue #166 / sprint
// Block A.5). External consumers import from
// `weaver_embedding::grpc_client` and `weaver_embedding::proto::embedding`.
// `weaver_spu::encoder::grpc_client_legacy` and `weaver_spu::proto::embedding`.
// `weaver-database`'s `proto` module continues to generate
// embedding-service types for backward compat with internal
// proto-validation tests; a future cleanup PR removes the
Expand Down
5 changes: 4 additions & 1 deletion crates/weaver-demo/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ license.workspace = true
[dependencies]
weaver-core = { workspace = true }
weaver-database = { workspace = true }
weaver-embedding = { workspace = true }
# `weaver-embedding` removed in PR-0.5.E. Demo uses the relocated
# encoder types via `weaver-spu` directly + the relocated `Embedder`
# trait via `weaver-core::embedder`.
weaver-spu = { workspace = true }
weaver-trace = { workspace = true }
weaver-analysis = { workspace = true }
async-trait = { workspace = true }
Expand Down
Loading