refactor(core): relocate Embedder trait from weaver-embedding to weaver-core (PR-0.5.B)

crates/weaver-core/Cargo.toml

@@ -23,8 +23,23 @@ tracing = { workspace = true }
 tracing-subscriber = { workspace = true }
 tracing-appender = { workspace = true }
 uuid = { workspace = true }
+# `tonic` is a workspace-level transport dep used here only for the
+# `From<tonic::transport::Error> for EmbeddingError` and
+# `From<tonic::Status> for EmbeddingError` impls in `embedder.rs`.
+# Orphan rules require these impls to live in the trait's crate
+# (weaver-core); they're how the gRPC backend in `weaver-embedding`
+# (and elsewhere) propagates transport-layer errors via `?` into the
+# abstract `EmbeddingError::Transport` variant. Removed in PR-3.A
+# along with the gRPC client itself.
+tonic = { workspace = true }
 weaver-database = { workspace = true }
-weaver-embedding = { workspace = true }
+# `weaver-embedding` was a direct dep until PR-0.5.B. Its only use was
+# constructing `EmbeddingClient` directly inside `tools/memory/codebase_search.rs`.
+# That call site now goes through `ExecutionContext.embedder`
+# (`Arc<dyn weaver_core::embedder::Embedder>`), which the daemon
+# populates at boot. Dropping the dep breaks the cycle that would form
+# once `weaver-embedding` adds its own `weaver-core` dep for the
+# relocated trait.
 # Production dep as of Phase 1a Stage 1.2 — `engine::query` calls
 # `weaver_trace::current_span_id()` to capture the TOOL span's id at
 # tool-execute time so the resulting `MemoryRetrieval` block can carry